Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates on summary plot of GEM onlineDQM #35952

Merged
merged 2 commits into from Nov 3, 2021

Conversation

quark2
Copy link
Contributor

@quark2 quark2 commented Nov 2, 2021

PR description:

The criteria of the summary plot of GEM onlineDQM have been changed: From now on it goes red(error)/yellow(warning) which is determined by the ratio of error/warning status on each chamber.

Also binning of some plots have been changed to watch some recHit distribution more carefully.

It will be good for this update to be implemented to the current central DQM, so a backport to 12_0_X will be made soon.

PR validation:

Test are done and one can check again by runTheMatrix workflows

@jshlee @watson-ij

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35952/26360

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2021

A new Pull Request was created by @quark2 for master.

It involves the following packages:

  • DQM/GEM (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please review it and eventually sign? Thanks.
@watson-ij this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@jfernan2
Copy link
Contributor

jfernan2 commented Nov 2, 2021

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8402e0/20198/summary.html
COMMIT: 7de9d5d
CMSSW: CMSSW_12_2_X_2021-11-02-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35952/20198/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 42
  • DQMHistoTests: Total histograms compared: 2901890
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 210
  • DQMHistoTests: Total successes: 2901658
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1220.707 KiB( 41 files compared)
  • DQMHistoSizes: changed ( 10024.0,... ): 23.047 KiB GEM/RecHits
  • DQMHistoSizes: changed ( 11634.0,... ): 46.094 KiB GEM/RecHits
  • DQMHistoSizes: changed ( 23234.0,... ): 92.188 KiB GEM/RecHits
  • DQMHistoSizes: changed ( 35034.0,... ): 214.844 KiB GEM/RecHits
  • Checked 177 log files, 37 edm output root files, 42 DQM output files
  • TriggerResults: no differences found

@jfernan2
Copy link
Contributor

jfernan2 commented Nov 3, 2021

@quark2 I don't understand why the backport of this PR did not produce changes in Offline DQM workflows,

https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_12_0_X_2021-11-02-1100+271e3e/46605/dqm-histo-comparison-summary.html

but this master version did produce them:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_12_2_X_2021-11-02-1100+8402e0/46616/dqm-histo-comparison-summary.html

Any idea? Aren't the PRs identical? From an eye inspection they do look the same

@quark2
Copy link
Contributor Author

quark2 commented Nov 3, 2021

Hi @jfernan2,

Yes, these PRs are identical. But in CMSSW_12_2_X the plots under some changes (change of the bins, see here) are used in the workflow while they are not in CMSSW_12_0_X.

Best regards,
Byeonghak Ko

@jfernan2
Copy link
Contributor

jfernan2 commented Nov 3, 2021

I do not understand @quark2 sorry
Where and when you set to use GEMRecHit source in Offline? I missed that part
Thanks

@quark2
Copy link
Contributor Author

quark2 commented Nov 3, 2021

Ahh, some plots on GEM onlineDQM is also used in GEM offlineDQM (and GEM validation). See this one in the master branch, and compare it with this which is the same file but in CMSSW_12_0_X.

Best regards,
Byeonghak Ko

@jfernan2
Copy link
Contributor

jfernan2 commented Nov 3, 2021

OK, I see, thanks for the explanation

@jfernan2
Copy link
Contributor

jfernan2 commented Nov 3, 2021

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2021

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Nov 3, 2021

+1

@cmsbuild cmsbuild merged commit e64ef64 into cms-sw:master Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants