New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates on summary plot of GEM onlineDQM #35952
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35952/26360
|
A new Pull Request was created by @quark2 for master. It involves the following packages:
@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8402e0/20198/summary.html Comparison SummarySummary:
|
@quark2 I don't understand why the backport of this PR did not produce changes in Offline DQM workflows, but this master version did produce them: Any idea? Aren't the PRs identical? From an eye inspection they do look the same |
I do not understand @quark2 sorry |
OK, I see, thanks for the explanation |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
The criteria of the summary plot of GEM onlineDQM have been changed: From now on it goes red(error)/yellow(warning) which is determined by the ratio of error/warning status on each chamber.
Also binning of some plots have been changed to watch some recHit distribution more carefully.
It will be good for this update to be implemented to the current central DQM, so a backport to 12_0_X will be made soon.
PR validation:
Test are done and one can check again by
runTheMatrix
workflows@jshlee @watson-ij