Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix thread safety issue with PosteriorWeightsCalculator #3600

Conversation

Dr15Jones
Copy link
Contributor

Changed the code to call the thread safe version of KfComponentsHolder::setup
which avoids uses of a static.

Changed the code to call the thread safe version of KfComponentsHolder::setup
which avoids uses of a static.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_1_X.

Fix thread safety issue with PosteriorWeightsCalculator

It involves the following packages:

TrackingTools/GsfTracking

@nclopezo, @cmsbuild, @anton-a, @thspeer, @slava77, @Degano can you please review it and eventually sign? Thanks.
@gpetruc, @cerati, @GiacomoSguazzoni, @rovere, @venturia this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@nclopezo
Copy link
Contributor

nclopezo commented May 2, 2014

I am having troubles again with git-cms-merge-topic.

fatal: Couldn't find remote ref refs/pull/3600/head

The tests are running, I will post the results by hand.

@slava77
Copy link
Contributor

slava77 commented May 5, 2014

+1

for #3600 f8b69a2

jenkins ok

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

ktf added a commit that referenced this pull request May 5, 2014
…ghtsCalculator

Reco -- Fix thread safety issue with PosteriorWeightsCalculator
@ktf ktf merged commit 9cb8489 into cms-sw:CMSSW_7_1_X May 5, 2014
@Dr15Jones Dr15Jones deleted the fixThreadSafetyInPosteriorWeightsCalculator branch May 6, 2014 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants