New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated storage of flavor information in pat::Jet #3601
Updated storage of flavor information in pat::Jet #3601
Conversation
…ule for backward compatibility
A new Pull Request was created by @ferencek (Dinko Ferencek) for CMSSW_7_1_X. Updated storage of flavor information in pat::Jet It involves the following packages: DataFormats/PatCandidates @civanch, @nclopezo, @mdhildreth, @monttj, @cmsbuild, @vadler, @Degano can you please review it and eventually sign? Thanks. |
+1 |
+1 |
@@ -114,10 +114,13 @@ | |||
<class name="pat::Jet" ClassVersion="12"> | |||
<field name="caloTowersTemp_" transient="true"/> | |||
<field name="pfCandidatesTemp_" transient="true"/> | |||
<version ClassVersion="12" checksum="398641970"/> | |||
<version ClassVersion="12" checksum="862613450"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please restore the old ClassVersion 12, which is in 710pre7 and add a new ClassVersion 13.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vadler We discussed this already via email and I don't want to be a pest, but what is the reason for keeping the preliminary ClassVersion 12. It will never be used by anybody, it's in not clear how to correctly define an IOREAD rule for it (or at least it is not clear to me), and most importantly, the preliminary ClassVersion 12 ended up in 710pre7 basically by accident (the PR was approved and merged before we finished discussing offline how to best incorporate the updated jet flavor information in the pat::Jet class). In addition, there are also backport PRs in which one would go from ClassVersion 11 to 13 for no good reason. Is there some formal rule about ClassVersions in pre-releases that I'm breaking by just updating the checksum between two pre-releases?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, then let's condider the compatibility with 710pre7 broken for this feature.
+1 |
…om-CMSSW_7_1_X_2014-04-29-0200 Updated storage of flavor information in pat::Jet
This PR changes the data members of pat::Jet storing the flavor information. For backward compatibility an IOREAD rule has been added.
Update (May 6, 2014): Replaced the 'consumes' call for leptons by 'mayConsume' in response to the problem observed in #3256