Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GEMGeometryAnalyzer - added first and last strip global position #36102

Merged
merged 2 commits into from Nov 29, 2021

Conversation

jshlee
Copy link
Contributor

@jshlee jshlee commented Nov 12, 2021

PR description:

Added first and last strip global position in the GEMGeometryAnalyzer to help debug/validate the geometry.

PR validation:

GEMGeometryAnalyzer doesn't run in any of the workflows but tested with 34611.0 anyways.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36102/26596

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @jshlee (Jason Lee) for master.

It involves the following packages:

  • Geometry/GEMGeometry (geometry, upgrade)

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob can you please review it and eventually sign? Thanks.
@dildick, @bsunanda, @slomeo, @fabiocos, @watson-ij this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@civanch
Copy link
Contributor

civanch commented Nov 12, 2021

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21536d/20498/summary.html
COMMIT: 0ba0259
CMSSW: CMSSW_12_2_X_2021-11-12-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36102/20498/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 42
  • DQMHistoTests: Total histograms compared: 2902040
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2902018
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 41 files compared)
  • Checked 177 log files, 37 edm output root files, 42 DQM output files
  • TriggerResults: no differences found

@cvuosalo
Copy link
Contributor

+1

@jshlee
Copy link
Contributor Author

jshlee commented Nov 29, 2021

can this be merged?

@perrotta
Copy link
Contributor

@cms-sw/upgrade-l2 this looks like a rather simple update of a private (\test) GME analyzer: do you have any comment on it?

@srimanob
Copy link
Contributor

+Upgrade

Adding information on GEMGeometryAnalyzer, no change is expected.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants