Migrate module config in Configuration, TauAnalysis to use default cfipython #36137
Conversation
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36137/26666
|
|
A new Pull Request was created by @jeongeun (JeongEun Lee) for master. It involves the following packages:
@jpata, @cmsbuild, @civanch, @mdhildreth, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
@cmsbuild please test |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1003cf/20566/summary.html Comparison SummarySummary:
|
|
+1 |
| @@ -14,12 +14,12 @@ | |||
| fileNames = cms.untracked.vstring('file:/u1/meridian/data/h4/2006/h4b.00013247.A.0.0.root') | |||
| ) | |||
|
|
|||
| process.ecal2006TBRecHit = cms.EDProducer("EcalRecHitProducer", | |||
| process.load("RecoLocalCalo.EcalRecProducers.ecalRecHit_cfi") | |||
There was a problem hiding this comment.
I'm curious why you use process.load instead of
from RecoLocalCalo.EcalRecProducers.ecalRecHit_cfi import ecalRecHit as _mod
as in the past? I may have simply missed the reason.
There was a problem hiding this comment.
OK, I think it's because this file has process already defined, so it's keeping the same style.
| process.bunchSpacingProducer = cms.EDProducer("BunchSpacingProducer") | ||
| process.bunchSpacingProducer.bunchSpacingOverride = cms.uint32(25) | ||
| process.bunchSpacingProducer.overrideBunchSpacing = cms.bool(True) | ||
| process.load('RecoLuminosity.LumiProducer.bunchSpacingProducer_cfi') |
There was a problem hiding this comment.
Here as well the same question as above. Also, I wonder if it would be better to put the import in the beginning of the file, like
from RecoLuminosity.LumiProducer.bunchSpacingProducer_cfi import bunchSpacingProducer as _bunchSpacingProducer
|
+reconstruction
|
cmsbuild
added
fully-signed
reconstruction-approved
and removed
reconstruction-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
PR description:
Optimization of the python configurations: Improve maintainability by cleaning up the duplicated and cloning from the default/reference configurations.
In this PR, 2 files were changed.
modified: Configuration/EcalTB/python/reco_application_2006_calibrate_cfg.py
modified: TauAnalysis/MCEmbeddingTools/python/customisers.py
PR validation:
Event Content comparison check was also done and there is no change with these updates.
Tested in CMSSW_12_2_X, the basic test all passed in the CMSSW PR instructions.