New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Making beamspot DIP server more verbose and additional fixes [12_2_X] (forward port to master) #36152
Conversation
please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36152/26696
|
A new Pull Request was created by @sikler (Ferenc Siklér) for master. It involves the following packages:
@emanueleusai, @ahmad3213, @jfernan2, @rvenditti, @pbo0, @pmandrik can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@@ -57,7 +57,7 @@ BeamSpotDipServer::BeamSpotDipServer(const edm::ParameterSet& ps) { | |||
dip = Dip::create("CmsBeamSpotServer"); | |||
|
|||
// | |||
dip->setDNSNode("dipns1,dipns2"); | |||
dip->setDNSNode("cmsdimns1.cern.ch"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not configure it via parameter set?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @smuzaffar! There are a few other suggestions that you gave in the past on the DIP client and that I have on my todo list for future improvements of this plugin. Is it ok if I add this one to the list and we take care of it in the future?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure, it is ok.
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-76d360/20582/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Forward port of #35860 to master