New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sibling Doublets for the HGCal Pattern Recoginition by CA #36171
Conversation
RecoHGCal/TICL/plugins/HGCGraph.cc
Outdated
const std::vector<reco::CaloCluster> &layerClusters, | ||
float maxRSquared) { | ||
float etaDiff = layerClusters[outerIdx].eta() - layerClusters[innerIdx].eta(); | ||
float phiDiff = layerClusters[outerIdx].phi() - layerClusters[innerIdx].phi(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will this bring wraparound issues? maybe better to use a deltaR function?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right! replaced with deltaR2 method
@cmsbuild please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36171/26729
|
A new Pull Request was created by @waredjeb (Wahid Redjeb) for master. It involves the following packages:
@jpata, @AdrianoDee, @srimanob, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36171/26732
|
tmp.edges().reserve(ntuplet.size()); | ||
for (auto const &t : ntuplet) { | ||
std::array<unsigned int, 2> edge = { | ||
{(unsigned int)doublets[t].innerClusterId(), (unsigned int)doublets[t].outerClusterId()}}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from 4.15 http://cms-sw.github.io/cms_coding_rules.html#4--technical-coding-rules-1
{(unsigned int)doublets[t].innerClusterId(), (unsigned int)doublets[t].outerClusterId()}}; | |
{static_cast<unsigned int>(doublets[t].innerClusterId()), static_cast<unsigned int>(doublets[t].outerClusterId())}}; |
RecoHGCal/TICL/python/EMStep_cff.py
Outdated
@@ -29,6 +29,7 @@ | |||
shower_start_max_layer = 5, #inclusive | |||
max_out_in_hops = 1, | |||
skip_layers = 2, | |||
siblings_maxRSquared = [6e-4, 6e-4, 6e-4], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
siblings_maxRSquared = [6e-4, 6e-4, 6e-4], |
not needed here (the same as the default already).
Same comment for the other files below
Hi @waredjeb , If @rovere and @felicepantaleo agree and since you are in there please correct |
Hi,
|
@waredjeb @rovere |
enable profiling |
@cmsbuild please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-af02b3/20966/summary.html Comparison SummarySummary:
|
@waredjeb has made some further studies on photons (he can link his plots here, for record). Given the improved fakerate of photons, and also gain in timing[1], the small efficiency loss seems tolerable to me.
|
+reconstruction
|
@waredjeb @swagata87 |
Hi @srimanob, sure. Here you can find the new plots https://wredjeb.web.cern.ch/HGCAL/PRTest/plots/, workflow 35252.0 PU200.
The photons fake rate increases a bit with this PR. We had an offline discussion with Soham, who said that given the CPU time reduction, the small changes are fine. |
@cms-sw/upgrade-l2 |
+Upgrade Slightly change of photon fake rate is expected from this PR. |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This pull request introduces the Sibling Doublets for the HGCal Pattern Recognition.
This feature has been already discussed in the last Reconstruction and Analysis Tools meeting (link to presentation, slide 14)
This PR
@rovere @felicepantaleo @cseez @pfs