Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using SOI+1 energy from MAHI as auxEnergy when M3 is not run #36211

Merged
merged 1 commit into from Nov 27, 2021

Conversation

igv4321
Copy link
Contributor

@igv4321 igv4321 commented Nov 22, 2021

PR description:

Adding SOI+1 energy from MAHI to HBHERecHit as auxEnergy when "Method 3" is not run. No changes expected in the output when "Method 3" is run. When it is not run, the "eaux()" method of the rechit will return a meaningful number instead of just 0.

A few minor changes were also made, streamlining MAHI code.

This change enables subsequent studies of SOI+1 energy for reconstructing long-lived particles.

PR validation:

The usual "runTheMatrix.py" tests were run.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36211/26817

  • This PR adds an extra 24KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @igv4321 (Igor Volobouev) for master.

It involves the following packages:

  • RecoLocalCalo/HcalRecAlgos (reconstruction)

@jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@apsallid, @rchatter, @argiro, @bsunanda, @thomreis, @simonepigazzini, @mariadalfonso, @abdoulline this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@slava77
Copy link
Contributor

slava77 commented Nov 23, 2021

@cmsbuild please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18126a/20705/summary.html
COMMIT: 7b7cae6
CMSSW: CMSSW_12_2_X_2021-11-23-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36211/20705/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 78 differences found in the comparisons
  • DQMHistoTests: Total files compared: 42
  • DQMHistoTests: Total histograms compared: 3247025
  • DQMHistoTests: Total failures: 180
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3246823
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 41 files compared)
  • Checked 177 log files, 37 edm output root files, 42 DQM output files
  • TriggerResults: no differences found

@abdoulline
Copy link

HCAL Reco changes (and HLT ones, which include HCAL Reco) all come from re-filled "M3" plots, as expected.

@slava77
Copy link
Contributor

slava77 commented Nov 26, 2021

@igv4321 @abdoulline
was it considered to fill some aux flag to denote what's filled in the auxEnergy?
Is it safe enough to assume the correct interpretation is made with this data based on just the original dataset provenance/configuration?

@slava77
Copy link
Contributor

slava77 commented Nov 26, 2021

(e.g. in 34834.999) the DQM still treats eaux as M3
wf34834 999_M3_HB4

is there a PR planned to update this to avoid confusion?

@abdoulline
Copy link

abdoulline commented Nov 27, 2021

@slava77
Indeed, "M3" plots refilled, as I metioned (that we did plan) previously in #35807 :
#35807 (comment)

and also here in message above #36211 (comment)

I believe it's a minor point - the name "M3" of the plot(s), as we know it stands for "auxEnergy" (really auxiliary information, not involved in the everyday HCAL Validation, looked at occasionally by HCAL Offline Validation responsible = me) and we'll change it in the next round of HCAL DQM cumulative update from "M3" to more general "auxEnergy".

When useM3 = False (for >=Run3) it comes from MAHI SOI+1. And we'll not get back to M3 in the future.

@slava77
Copy link
Contributor

slava77 commented Nov 27, 2021

+reconstruction

for #36211 7b7cae6

  • code changes are in line with the PR description; based on Using SOI+1 energy from MAHI as auxEnergy when M3 is not run #36211 (comment) it sounds like HCAL DPG prefers/plans to keep track of the content in eaux based on info of the origins of the sample (or its configuration, like starting from latest releases with Run3 era modifier)
  • jenkins tests pass and comparisons with the baseline show differences in eaux as expected

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit d5a5c0f into cms-sw:master Nov 27, 2021
@igv4321 igv4321 deleted the soi_plus_one branch May 18, 2022 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants