New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using SOI+1 energy from MAHI as auxEnergy when M3 is not run #36211
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36211/26817
|
A new Pull Request was created by @igv4321 (Igor Volobouev) for master. It involves the following packages:
@jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18126a/20705/summary.html Comparison SummarySummary:
|
HCAL Reco changes (and HLT ones, which include HCAL Reco) all come from re-filled "M3" plots, as expected. |
@igv4321 @abdoulline |
@slava77 and also here in message above #36211 (comment) I believe it's a minor point - the name "M3" of the plot(s), as we know it stands for "auxEnergy" (really auxiliary information, not involved in the everyday HCAL Validation, looked at occasionally by HCAL Offline Validation responsible = me) and we'll change it in the next round of HCAL DQM cumulative update from "M3" to more general "auxEnergy". When useM3 = False (for >=Run3) it comes from MAHI SOI+1. And we'll not get back to M3 in the future. |
+reconstruction
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Adding SOI+1 energy from MAHI to HBHERecHit as auxEnergy when "Method 3" is not run. No changes expected in the output when "Method 3" is run. When it is not run, the "eaux()" method of the rechit will return a meaningful number instead of just 0.
A few minor changes were also made, streamlining MAHI code.
This change enables subsequent studies of SOI+1 energy for reconstructing long-lived particles.
PR validation:
The usual "runTheMatrix.py" tests were run.