Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read out the CSC cathode shower in TMB/OTMB (HadronicShowerTrigger-9) #36223

Merged
merged 1 commit into from Dec 2, 2021
Merged

Read out the CSC cathode shower in TMB/OTMB (HadronicShowerTrigger-9) #36223

merged 1 commit into from Dec 2, 2021

Conversation

dildick
Copy link
Contributor

@dildick dildick commented Nov 23, 2021

PR description:

Read out the CSC cathode shower in TMB/OTMB. Previously the L1T CSC TP emulator read out the anode showers, and the combined showers. This minor update also adds the cathode showers formed in the CLCT logic on the TMB/OTMB.

PR validation:

Code compiles. Tested WF with 11634.0

if this PR is a backport please specify the original PR and why you need to backport that PR:

N.A.

@tahuang1991 @barvic @giovanni-mocellin @Nik-Menendez

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36223/26834

  • This PR adds an extra 36KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @dildick (Sven Dildick) for master.

It involves the following packages:

  • L1Trigger/CSCTriggerPrimitives (l1)

@cmsbuild, @rekovic, @cecilecaillol can you please review it and eventually sign? Thanks.
@valuev, @missirol, @ptcox, @Martin-Grunewald this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@dildick
Copy link
Contributor Author

dildick commented Nov 29, 2021

Can someone run the tests, please?

@qliphy
Copy link
Contributor

qliphy commented Nov 29, 2021

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ede9b0/20823/summary.html
COMMIT: 9823a3d
CMSSW: CMSSW_12_2_X_2021-11-28-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36223/20823/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 42
  • DQMHistoTests: Total histograms compared: 3247873
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3247851
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 41 files compared)
  • Checked 177 log files, 37 edm output root files, 42 DQM output files
  • TriggerResults: no differences found

@dildick
Copy link
Contributor Author

dildick commented Dec 1, 2021

@rekovic Can this PR be signed off? Thanks!

@rekovic
Copy link
Contributor

rekovic commented Dec 1, 2021

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 1, 2021

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@dildick
Copy link
Contributor Author

dildick commented Dec 1, 2021

@qliphy Can you please sign? Thanks!

@perrotta
Copy link
Contributor

perrotta commented Dec 2, 2021

+1

@cmsbuild cmsbuild merged commit 078a173 into cms-sw:master Dec 2, 2021
@dildick dildick deleted the from-CMSSW_12_2_X_2021-11-23-1100-readout-csc-cathode-showers branch December 2, 2021 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants