Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HcalDQM: Update for Run3 based on recent commissioning runs #36232

Merged
merged 1 commit into from Nov 25, 2021

Conversation

lwang046
Copy link
Contributor

@lwang046 lwang046 commented Nov 24, 2021

PR description:

Removed all VME related plots and tasks because no VME in Hcal anymore.
Added and modified some plots in the TPTask --> Affects TPTask
Made change to the charge averaged time calculation requested from Hcal operation colleagues--> affects DigiTask
Reduce the y-axis of FiberuTCAFiberCh to exclude channels. --> Affects RawTask

PR validation:

Tested with cmsRun hcal_dqm_sourceclient-live_cfg.py and cmsRun hcalreco_dqm_sourceclient-live_cfg.py on recent data, private DQM plots reflects the desired changes.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36232/26861

  • This PR adds an extra 76KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @lwang046 for master.

It involves the following packages:

  • DQM/HcalCommon (dqm)
  • DQM/HcalTasks (dqm)
  • DQM/Integration (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please review it and eventually sign? Thanks.
@DryRun, @battibass, @abdoulline, @bsunanda, @francescobrivio, @threus, @batinkov this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@abdoulline
Copy link

@lwang046 commissions -> commissioning (runs) ?

@lwang046 lwang046 changed the title HcalDQM: Update for Run3 based on recent commissions runs HcalDQM: Update for Run3 based on recent commissioning runs Nov 24, 2021
@jfernan2
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a1d748/20738/summary.html
COMMIT: 3280399
CMSSW: CMSSW_12_2_X_2021-11-23-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36232/20738/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 42
  • DQMHistoTests: Total histograms compared: 3246897
  • DQMHistoTests: Total failures: 321
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3246554
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 4548.004 KiB( 41 files compared)
  • DQMHistoSizes: changed ( 1000.0,... ): 1056.473 KiB Hcal/TPTask
  • DQMHistoSizes: changed ( 1000.0,... ): 11.504 KiB Hcal/DigiTask
  • Checked 177 log files, 37 edm output root files, 42 DQM output files
  • TriggerResults: no differences found

@jfernan2
Copy link
Contributor

@lwang046 there seems to be a shift in the timing: https://tinyurl.com/ydjyn9n2
In other cases plots are added but empty: https://tinyurl.com/yflw9ra8 https://tinyurl.com/yfsqam6f
Is that expected?

@lwang046
Copy link
Contributor Author

lwang046 commented Nov 24, 2021

Hi @jfernan2 yeah in the first case the time is calculated as charge averaged time without subtracting noise, a right shift looks reasonable from the calculation formula

for (unsigned int i = i_start; i <= i_end; ++i) {
         double q = dopedsubtr ? adc2fCDBMinusPedestal(conditions, calo_samples, did, digi, i) : calo_samples[i];
         sumQ += q;
         sumQT += (i + 1) * q;
}
return (sumQ > 0 ? sumQT / sumQ - 1 : constants::GARBAGE_VALUE);

In the second case there is a strong energy cut (>~1GeV) on the digis that can enter the plot, it's no surprise when these plots are empty

@jfernan2
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 5a139d4 into cms-sw:master Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants