New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HcalDQM: Update for Run3 based on recent commissioning runs #36232
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36232/26861
|
A new Pull Request was created by @lwang046 for master. It involves the following packages:
@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@lwang046 commissions -> commissioning (runs) ? |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a1d748/20738/summary.html Comparison SummarySummary:
|
@lwang046 there seems to be a shift in the timing: https://tinyurl.com/ydjyn9n2 |
Hi @jfernan2 yeah in the first case the time is calculated as charge averaged time without subtracting noise, a right shift looks reasonable from the calculation formula
In the second case there is a strong energy cut (>~1GeV) on the digis that can enter the plot, it's no surprise when these plots are empty |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Removed all VME related plots and tasks because no VME in Hcal anymore.
Added and modified some plots in the TPTask --> Affects TPTask
Made change to the charge averaged time calculation requested from Hcal operation colleagues--> affects DigiTask
Reduce the y-axis of FiberuTCAFiberCh to exclude channels. --> Affects RawTask
PR validation:
Tested with
cmsRun hcal_dqm_sourceclient-live_cfg.py
andcmsRun hcalreco_dqm_sourceclient-live_cfg.py
on recent data, private DQM plots reflects the desired changes.