Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few fixes for DQM/L1TMonitor L1TGT and L1TRate #36233

Merged
merged 1 commit into from Nov 24, 2021

Conversation

perrotta
Copy link
Contributor

PR description:

Starting from the identification of some dead assignment in DQM/L1TMonitor/src/L1TRate.cc and DQM/L1TMonitor/src/L1TGT.cc by the static analyzer I noticed something that looked like a bug in the implementation of the logic.
The fixes look simple enough, and I propose them here for having them evaluated by the responsibles of the code

PR validation:

It builds without errors

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36233/26863

  • This PR adds an extra 24KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @perrotta (Andrea Perrotta) for master.

It involves the following packages:

  • DQM/L1TMonitor (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-636610/20735/summary.html
COMMIT: 712c0ab
CMSSW: CMSSW_12_2_X_2021-11-23-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36233/20735/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 42
  • DQMHistoTests: Total histograms compared: 3247025
  • DQMHistoTests: Total failures: 11
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3246991
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 41 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 177 log files, 37 edm output root files, 42 DQM output files
  • TriggerResults: no differences found

@perrotta perrotta changed the title A few fixes for L1TGT and L1TRate A few fixes for DQM/L1TMonitor L1TGT and L1TRate Nov 24, 2021
@jfernan2
Copy link
Contributor

+1
Changes are fine from my side. @vukasinmilosevic , as L1T DQM developer, can you please green light or not?

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@vukasinmilosevic
Copy link
Contributor

vukasinmilosevic commented Nov 24, 2021

Looks ok from my side as well.

@perrotta
Copy link
Contributor Author

+1

@cmsbuild cmsbuild merged commit 1f763d4 into cms-sw:master Nov 24, 2021
@perrotta perrotta deleted the fixesForDqmL1TMonitor branch November 24, 2021 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants