[ASAN] fix unit tests by setting NO_TEST_PREFIX flag for ASAN IB

[smuzaffar]

Unit tests for DQM/Integration hang [a] for ASAN IBs as scram sets LD_PRELOAD=libasan.so for each unit tests. Running tests without LD_PRELOAD works. cms-sw/cmsdist#7469 Allows tests to instruct scram to not add test prefix. This should fix the unit tests for ASAN IBs.

[a] https://cmssdt.cern.ch/SDT/cgi-bin/logreader/slc7_amd64_gcc10/CMSSW_12_2_ASAN_X_2021-11-24-2300/unitTestLogs/DQM/Integration#/

===== Test "TestDQMOnlineClient-beam_dqm_sourceclient" ====
+ [[ 1 -eq 0 ]]
+ [[ -z '' ]]
+ LOCAL_TEST_DIR=.
+ [[ -z '' ]]
+ CLIENTS_DIR=./src/DQM/Integration/python/clients
+ mkdir -p ./upload
+ cmsRun ./src/DQM/Integration/python/clients/beam_dqm_sourceclient-live_cfg.py unitTest=True
Querying DAS for files...
the query is file run=344518 dataset=/ExpressCosmics/Commissioning2021-Express-v1/FEVT lumi=1

---> test TestDQMOnlineClient-beam_dqm_sourceclient had ERRORS
TestTime:3600
^^^^ End Test TestDQMOnlineClient-beam_dqm_sourceclient ^^^^

[smuzaffar]

FYI @iarspider

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36249/26902

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

• DQM/Integration (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please review it and eventually sign? Thanks.
@battibass, @threus, @batinkov, @francescobrivio this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[smuzaffar]

please test

[smuzaffar]

please test with cms-sw/cmsdist#7469 for CMSSW_12_2_ASAN_X

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f066d8/20762/summary.html
COMMIT: fa3bdc4
CMSSW: CMSSW_12_2_X_2021-11-24-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36249/20762/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 42
• DQMHistoTests: Total histograms compared: 3247745
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3247723
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 41 files compared)
• Checked 177 log files, 37 edm output root files, 42 DQM output files
• TriggerResults: no differences found

[cmsbuild]

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f066d8/20765/summary.html
COMMIT: fa3bdc4
CMSSW: CMSSW_12_2_ASAN_X_2021-11-24-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36249/20765/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @cms-sw added missing cmssw-cs8 script cmsdist#7468
• @ddaina rollback config -> wrapper cmsdist#7467
• @cms-sw Added cs8 support, remove harded coded usage of amd64 cmsdist#7466

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f066d8/20765/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f066d8/20765/git-merge-result

Unit Tests

I found errors in the following unit tests:

---> test TestDQMOnlineClient-dt_dqm_sourceclient had ERRORS
---> test TestDQMOnlineClient-dt4ml_dqm_sourceclient had ERRORS
---> test TestDQMServicesDemo had ERRORS
---> test TestDQMOnlineClient-pixellumi_dqm_sourceclient had ERRORS
and more ...

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• Reco comparison had 71 failed jobs
• DQMHistoTests: Total files compared: 42
• DQMHistoTests: Total histograms compared: 3247745
• DQMHistoTests: Total failures: 1084500
• DQMHistoTests: Total nulls: 27
• DQMHistoTests: Total successes: 2163196
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.17 KiB( 41 files compared)
• DQMHistoSizes: changed ( 10224.0 ): 0.117 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 250202.181 ): -0.533 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 25202.0 ): 0.246 KiB SiStrip/MechanicalView
• Checked 177 log files, 37 edm output root files, 42 DQM output files

[jfernan2]

@smuzaffar I am able to reproduce the errors but, for the TestDQMOnlineClient-* I don't understand what has changed in ASAN to give those errors now since those modules have not changed since more than a year. I will research the DT related ones.

For the pixelLumi one, I let @sroychow to comment on the crash produced in: PixelLumiDQM::calculateBunchMask

For the TestDQMServicesDemo, this is being discussed on: #36063

[smuzaffar]

no idea @jfernan2 , there were many unit tests which were failing for ASAN IBs and few of those errors were hidden due to LD_PRELOAD=libasan. I suggest that sign this PR so and fix the ASAN issue for TestDQMOnlineClient-* in other PR.

[jfernan2]

no idea @jfernan2 , there were many unit tests which were failing for ASAN IBs and few of those errors were hidden due to LD_PRELOAD=libasan. I suggest that sign this PR so and fix the ASAN issue for TestDQMOnlineClient-* in other PR.

OK, I'll do as you suggest

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1

[jfernan2]

I have created this PR fixing the UnitTest crashes here: #36269
FYI @sroychow