Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[121X] Modify calculations for the Lorentz angle #36266

Merged
merged 1 commit into from Nov 28, 2021

Conversation

tvami
Copy link
Contributor

@tvami tvami commented Nov 26, 2021

PR description:

See describtion at #36241

if this PR is a backport please specify the original PR and why you need to backport that PR:

Backport of #36241

Needed for the T0 replay

@tvami tvami changed the title Modify calculations for the Lorentz angle [121X] Modify calculations for the Lorentz angle Nov 26, 2021
@cmsbuild cmsbuild added this to the CMSSW_12_1_X milestone Nov 26, 2021
@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 26, 2021

A new Pull Request was created by @tvami (Tamas Vami) for CMSSW_12_1_X.

It involves the following packages:

  • CalibTracker/SiPixelLorentzAngle (alca)

@cmsbuild, @malbouis, @tvami, @yuanchao, @francescobrivio can you please review it and eventually sign? Thanks.
@tocheng, @OzAmram, @ferencek, @mmusich, @dkotlins, @tvami this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@tvami
Copy link
Contributor Author

tvami commented Nov 26, 2021

type bug-fix

@tvami
Copy link
Contributor Author

tvami commented Nov 26, 2021

backport of #36241

@tvami
Copy link
Contributor Author

tvami commented Nov 26, 2021

@cmsbuild , please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-540032/20792/summary.html
COMMIT: 17b8322
CMSSW: CMSSW_12_1_X_2021-11-26-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36266/20792/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 42
  • DQMHistoTests: Total histograms compared: 2901440
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2901417
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 41 files compared)
  • Checked 177 log files, 37 edm output root files, 42 DQM output files
  • TriggerResults: no differences found

@francescobrivio
Copy link
Contributor

+alca

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Nov 28, 2021

+1
tested in master IB

@cmsbuild cmsbuild merged commit 6213a97 into cms-sw:CMSSW_12_1_X Nov 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants