Updated castor geometry seperated halves v2 #3627
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an update to:
#2722
We were asked to provide backward compatibility to old geometry. The numbering scheme now detects whether it's new or old geometry by looking for CASTFar/Near volumes which only exist in the (new) separated half geometry. With this change (even if old xml file or db is selected) no warning messages appear and det IDs are properly returned.
We can discuss this in simulation meeting on Friday...
(Including Hans @hvanhaev)