Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated castor geometry seperated halves v2 #3627

Merged

Conversation

cbaus
Copy link

@cbaus cbaus commented Apr 30, 2014

This is an update to:
#2722

We were asked to provide backward compatibility to old geometry. The numbering scheme now detects whether it's new or old geometry by looking for CASTFar/Near volumes which only exist in the (new) separated half geometry. With this change (even if old xml file or db is selected) no warning messages appear and det IDs are properly returned.
We can discuss this in simulation meeting on Friday...

(Including Hans @hvanhaev)

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @cbaus for CMSSW_7_1_X.

Updated castor geometry seperated halves v2

It involves the following packages:

SimG4CMS/Forward

@cmsbuild, @civanch, @Degano, @mdhildreth, @nclopezo can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 1, 2014

@cmsbuild
Copy link
Contributor

cmsbuild commented May 1, 2014

@civanch
Copy link
Contributor

civanch commented May 1, 2014

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented May 1, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

ktf added a commit that referenced this pull request May 1, 2014
…-halves-v2

Geometry -- Updated castor geometry seperated halves v2
@ktf ktf merged commit e688523 into cms-sw:CMSSW_7_1_X May 1, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants