New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run3-sim97 Make use of ESGetToken in examples for SimG4CMS/Calo #36288
Conversation
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36288/26990
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36288/26991
|
A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master. It involves the following packages:
@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild Please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-289900/20848/summary.html Comparison SummarySummary:
|
@bsunanda , the same question: is it thread safe or the test should work only in 1 thread? |
@civanch I think they are similar to SD's - better to be on a single thread - there is accumulation in the class members. Effort is needed to make them multithreaded |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36288/27013
|
Pull request #36288 was updated. @cmsbuild, @civanch, @mdhildreth can you please check and sign again. |
@cmsbuild Please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-289900/20865/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Make use of ESGetToken in examples for SimG4CMS/Calo
PR validation:
Use runTheMatrix test workflows
if this PR is a backport please specify the original PR and why you need to backport that PR:
Nothing special