Remove deprecation warnings from TrackingTools

[mmusich]

PR description:

Part of the migration in #31061
Went systematically through all of the CMSDEPRECATED_X warnings in the TrackingTools subsystem from CMSSW_12_2_CMSDEPRECATED_X_2021-12-03-2300
and removed deprecated API calls.

PR validation:

cmssw compiles after having retrieved dependencies with git cms-checkdeps -a.
.

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36391/27185

• This PR adds an extra 36KB to repository

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

• TrackingTools/PatternTools (reconstruction)
• TrackingTools/TrackAssociator (reconstruction)
• TrackingTools/TrackRefitter (reconstruction)
• TrackingTools/TrajectoryCleaning (reconstruction)
• TrackingTools/TrajectoryFiltering (reconstruction)
• TrackingTools/TransientTrack (reconstruction)

@jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@trocino, @Fedespring, @HuguesBrun, @calderona, @felicepantaleo, @abbiendi, @GiacomoSguazzoni, @JanFSchulte, @jhgoh, @VinInn, @bellan, @sscruz, @ebrondol, @rovere, @CeliaFernandez, @gpetruc, @lecriste, @mmusich, @mtosi, @dgulhan, @cericeci this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[mmusich]

@cmsbuild, please test

[mmusich]

@cmsbuild please abort

In the past 7 hours nothing happened.

[mmusich]

@cmsbuild, please test

[cmsbuild]

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6fac7c/21080/summary.html
COMMIT: 2595142
CMSSW: CMSSW_12_3_X_2021-12-07-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36391/21080/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

                 from /cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc900/cms/cmssw/CMSSW_12_3_X_2021-12-07-1100/src/Geometry/CommonDetUnit/interface/TrackingGeometry.h:1,
                 from /cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc900/cms/cmssw/CMSSW_12_3_X_2021-12-07-1100/src/Geometry/RPCGeometry/interface/RPCGeometry.h:12,
                 from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_3_X_2021-12-07-1100/src/RecoLocalMuon/RPCRecHit/plugins/TracktoRPC.cc:1:
/cvmfs/cms-ib.cern.ch/nweek-02710/slc7_amd64_gcc900/external/gcc/9.3.0/include/c++/9.3.0/bits/unique_ptr.h: In instantiation of 'typename std::_MakeUniq<_Tp>::__single_object std::make_unique(_Args&& ...) [with _Tp = TrackTransformerForCosmicMuons; _Args = {const edm::ParameterSet&}; typename std::_MakeUniq<_Tp>::__single_object = std::unique_ptr >]':
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_3_X_2021-12-07-1100/src/RecoLocalMuon/RPCRecHit/plugins/TracktoRPC.cc:62:83:   required from here
/cvmfs/cms-ib.cern.ch/nweek-02710/slc7_amd64_gcc900/external/gcc/9.3.0/include/c++/9.3.0/bits/unique_ptr.h:857:30: error: no matching function for call to 'TrackTransformerForCosmicMuons::TrackTransformerForCosmicMuons(const edm::ParameterSet&)'
  857 |     { return unique_ptr<_Tp>(new _Tp(std::forward<_Args>(__args)...)); }
      |                              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_3_X_2021-12-07-1100/src/RecoLocalMuon/RPCRecHit/plugins/TracktoRPC.h:46,
                 from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_3_X_2021-12-07-1100/src/RecoLocalMuon/RPCRecHit/plugins/TracktoRPC.cc:12:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_3_X_2021-12-07-1100/src/TrackingTools/TrackRefitter/interface/TrackTransformerForCosmicMuons.h:55:3: note: candidate: 'TrackTransformerForCosmicMuons::TrackTransformerForCosmicMuons(const edm::ParameterSet&, edm::ConsumesCollector)'


[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36391/27222

• This PR adds an extra 40KB to repository

[cmsbuild]

Pull request #36391 was updated. @jpata, @cmsbuild, @slava77 can you please check and sign again.

[mmusich]

@cmsbuild, please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6fac7c/21089/summary.html
COMMIT: 3ce67d7
CMSSW: CMSSW_12_3_X_2021-12-07-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36391/21089/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 42
• DQMHistoTests: Total histograms compared: 3250608
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3250586
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 41 files compared)
• Checked 177 log files, 37 edm output root files, 42 DQM output files
• TriggerResults: no differences found

[jpata]

+reconstruction

• technical
• no reco changes

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1