New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ensure HLTProcess
adds all (End)Path
s to the schedule
#36422
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36422/27239
|
A new Pull Request was created by @missirol (Marino Missiroli) for master. It involves the following packages:
@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test While the tests run, I'll do some more manual checks to confirm if these changes are okay. |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-becef1/21212/summary.html Comparison SummarySummary:
|
Tested the update of the static menus, and diff --git a/HLTrigger/Configuration/test/OnLine_HLT_HIon.py b/HLTrigger/Configuration/test/OnLine_HLT_HIon.py
index 7fb9004d0b3..a0f5c0f6bad 100644
--- a/HLTrigger/Configuration/test/OnLine_HLT_HIon.py
+++ b/HLTrigger/Configuration/test/OnLine_HLT_HIon.py
@@ -34667,6 +34667,7 @@ process.dqmOutput = cms.OutputModule("DQMRootOutputModule",
)
process.DQMOutput = cms.EndPath( process.dqmOutput )
+process.schedule.append( process.DQMOutput )
# add specific customizations
_customInfo = {} |
type bugfix @Martin-Grunewald @silviodonato @Sam-Harper : if you have opinions about backporting this to earlier releases (e.g. One might wonder why this issue came up only recently. I don't fully understand it, but it likely has to do with the change from |
I suggest to backport this PR to and only to 12_2_X, as it is the latest stable release we have. |
+hlt |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR updates
HLTProcess
(which controls the output ofhltGetConfiguration
), ensuring that(End)Path
s appended byHLTProcess
are added to the schedule.For example, if one currently specifies
--output minimal
, the corresponding output.root
file is not produced.The issue was spotted by @silviodonato.
Suggestions/corrections on the implemention are welcomed.
FYI: @fwyzard @Sam-Harper (in case you'd like to review)
PR validation:
Manual tests, e.g.
If this PR is a backport, please specify the original PR and why you need to backport that PR:
N/A