Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure HLTProcess adds all (End)Paths to the schedule #36422

Merged
merged 1 commit into from Dec 13, 2021

Conversation

missirol
Copy link
Contributor

@missirol missirol commented Dec 8, 2021

PR description:

This PR updates HLTProcess (which controls the output of hltGetConfiguration), ensuring that (End)Paths appended by HLTProcess are added to the schedule.

For example, if one currently specifies --output minimal, the corresponding output .root file is not produced.

The issue was spotted by @silviodonato.

Suggestions/corrections on the implemention are welcomed.

FYI: @fwyzard @Sam-Harper (in case you'd like to review)

PR validation:

Manual tests, e.g.

for ec in minimal full all none ; do
  hltGetConfiguration /dev/CMSSW_12_3_0/GRun --globaltag auto:run3_hlt --data \
    --customise HLTrigger/Configuration/customizeHLTforCMSSW.customiseFor2018Input \
    --input /store/data/Run2018D/EphemeralHLTPhysics7/RAW/v1/000/323/790/00000/B543D251-40F1-CB46-A6A1-046CF3D78D6D.root \
    --era Run2_2018 --output ${ec} --max-events 10 > hlt_${ec}.py
  cmsRun hlt_${ec}.py &> hlt_${ec}.log
  ls -ltra .
done
unset ec

If this PR is a backport, please specify the original PR and why you need to backport that PR:

N/A

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 8, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36422/27239

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 8, 2021

A new Pull Request was created by @missirol (Marino Missiroli) for master.

It involves the following packages:

  • HLTrigger/Configuration (hlt)

@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @silviodonato this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@missirol
Copy link
Contributor Author

please test

While the tests run, I'll do some more manual checks to confirm if these changes are okay.

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-becef1/21212/summary.html
COMMIT: 34cf265
CMSSW: CMSSW_12_3_X_2021-12-12-0000/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36422/21212/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 42
  • DQMHistoTests: Total histograms compared: 3250704
  • DQMHistoTests: Total failures: 11
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3250670
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 41 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 177 log files, 37 edm output root files, 42 DQM output files
  • TriggerResults: no differences found

@missirol
Copy link
Contributor Author

Tested the update of the static menus, and cff fragments, with this PR.
The only difference will be in OnLine_HLT_HIon.py (diff below). I reran the relevant addOnTests, and didn't encounter any issues.

diff --git a/HLTrigger/Configuration/test/OnLine_HLT_HIon.py b/HLTrigger/Configuration/test/OnLine_HLT_HIon.py
index 7fb9004d0b3..a0f5c0f6bad 100644
--- a/HLTrigger/Configuration/test/OnLine_HLT_HIon.py
+++ b/HLTrigger/Configuration/test/OnLine_HLT_HIon.py
@@ -34667,6 +34667,7 @@ process.dqmOutput = cms.OutputModule("DQMRootOutputModule",
 )
 
 process.DQMOutput = cms.EndPath( process.dqmOutput )
+process.schedule.append( process.DQMOutput )
 
 # add specific customizations
 _customInfo = {}

@missirol
Copy link
Contributor Author

type bugfix

@Martin-Grunewald @silviodonato @Sam-Harper : if you have opinions about backporting this to earlier releases (e.g. 12_1_X and/or 12_2_X), please let me know.

One might wonder why this issue came up only recently. I don't fully understand it, but it likely has to do with the change from HLTSchedule to schedule. For example, in the case of config dumps, HLT-only configs previously had no cms.Schedule object (b/c HLTSchedule was ignored when making the dump, see last sentence of #35842 (comment)), so all (End)Paths were run automatically.

@silviodonato
Copy link
Contributor

@Martin-Grunewald @silviodonato @Sam-Harper : if you have opinions about backporting this to earlier releases (e.g. 12_1_X and/or 12_2_X), please let me know.

I suggest to backport this PR to and only to 12_2_X, as it is the latest stable release we have.

@missirol
Copy link
Contributor Author

+hlt

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants