Fix WF 139.002 for muon showers (HadronicShowerTrigger-10)

[dildick]

PR description:

Fix WF 139.002 for muon showers. See #36426

PR validation:

Tested with 139.002.

Preparing to run 139.002 RunZeroBias2021+RunZeroBias2021+HLTDR3_2021+RECODR3_ZBOffline+HARVESTD2021ZB
cleaning up  139.002_RunZeroBias2021+RunZeroBias2021+HLTDR3_2021+RECODR3_ZBOffline+HARVESTD2021ZB  in  /uscms_data/d3/dildick/work/LastPR/CMSSW_12_3_X_2021-12-08-1100/src

# in: /uscms_data/d3/dildick/work/LastPR/CMSSW_12_3_X_2021-12-08-1100/src going to execute cd 139.002_RunZeroBias2021+RunZeroBias2021+HLTDR3_2021+RECODR3_ZBOffline+HARVESTD2021ZB
 echo '{
"346512" : [[250, 300]]
}' > step1_lumiRanges.log  2>&1
 

# in: /uscms_data/d3/dildick/work/LastPR/CMSSW_12_3_X_2021-12-08-1100/src going to execute cd 139.002_RunZeroBias2021+RunZeroBias2021+HLTDR3_2021+RECODR3_ZBOffline+HARVESTD2021ZB
 (dasgoclient --limit 0 --query 'lumi,file dataset=/ZeroBias/Commissioning2021-v1/RAW run=346512' --format json | das-selected-lumis.py 250,300 ) | sort -u > step1_dasquery.log  2>&1
 
---

# in: /uscms_data/d3/dildick/work/LastPR/CMSSW_12_3_X_2021-12-08-1100/src going to execute cd 139.002_RunZeroBias2021+RunZeroBias2021+HLTDR3_2021+RECODR3_ZBOffline+HARVESTD2021ZB
 cmsDriver.py step2  --process reHLT -s L1REPACK:Full,HLT:@relval2021 --conditions auto:run3_hlt --data  --eventcontent FEVTDEBUGHLT --datatier FEVTDEBUGHLT --era Run3 -n 100  --filein filelist:step1_dasquery.log --lumiToProcess step1_lumiRanges.log --fileout file:step2.root  > step2_RunZeroBias2021+RunZeroBias2021+HLTDR3_2021+RECODR3_ZBOffline+HARVESTD2021ZB.log  2>&1
 

# in: /uscms_data/d3/dildick/work/LastPR/CMSSW_12_3_X_2021-12-08-1100/src going to execute cd 139.002_RunZeroBias2021+RunZeroBias2021+HLTDR3_2021+RECODR3_ZBOffline+HARVESTD2021ZB
 cmsDriver.py step3  --conditions auto:run3_data -s RAW2DIGI,L1Reco,RECO,EI,PAT,ALCA:SiStripCalZeroBias+SiStripCalMinBias+TkAlMinBias+EcalESAlign,DQM:@rerecoZeroBias+@ExtraHLT+@miniAODDQM --datatier RECO,MINIAOD,DQMIO --eventcontent RECO,MINIAOD,DQM --data  --process reRECO --scenario pp --era Run3 --customise Configuration/DataProcessing/RecoTLR.customisePostEra_Run3 --procModifiers siPixelQualityRawToDigi -n 100  --filein  file:step2.root  --fileout file:step3.root  > step3_RunZeroBias2021+RunZeroBias2021+HLTDR3_2021+RECODR3_ZBOffline+HARVESTD2021ZB.log  2>&1
 

# in: /uscms_data/d3/dildick/work/LastPR/CMSSW_12_3_X_2021-12-08-1100/src going to execute cd 139.002_RunZeroBias2021+RunZeroBias2021+HLTDR3_2021+RECODR3_ZBOffline+HARVESTD2021ZB
 cmsDriver.py step4  -s HARVESTING:@rerecoZeroBias+@ExtraHLT+@miniAODDQM --conditions auto:run3_data --data  --filetype DQM --scenario pp --era Run3 -n 100  --filein file:step3_inDQM.root --fileout file:step4.root  > step4_RunZeroBias2021+RunZeroBias2021+HLTDR3_2021+RECODR3_ZBOffline+HARVESTD2021ZB.log  2>&1
 
139.002_RunZeroBias2021+RunZeroBias2021+HLTDR3_2021+RECODR3_ZBOffline+HARVESTD2021ZB Step0-PASSED Step1-PASSED Step2-PASSED Step3-PASSED  - time date Wed Dec  8 22:02:38 2021-date Wed Dec  8 21:48:53 2021; exit: 0 0 0 0
1 1 1 1 tests passed, 0 0 0 0 failed

if this PR is a backport please specify the original PR and why you need to backport that PR:

@barvic @kakwok @giovanni-mocellin

@barvic At some point you'll have to set useGEMs to True in preparation for Run-3.

[dildick]

@qliphy @perrotta This will be my last PR. I'm afraid I'm leaving the CMS collaboration this Friday. I'm actually on vacation on already...

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36428/27249

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @dildick (Sven Dildick) for master.

It involves the following packages:

• EventFilter/CSCRawToDigi (reconstruction)

@jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @ptcox, @barvic this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[qliphy]

@qliphy @perrotta This will be my last PR. I'm afraid I'm leaving the CMS collaboration this Friday. I'm actually on vacation on already...

thanks a lot!

[qliphy]

test parameters:
workflows = 139.002

[qliphy]

please test

[dildick]

@zuoxunwu FYI

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d5e5b4/21113/summary.html
COMMIT: 0665009
CMSSW: CMSSW_12_3_X_2021-12-08-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36428/21113/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-d5e5b4/139.002_RunZeroBias2021+RunZeroBias2021+HLTDR3_2021+RECODR3_ZBOffline+HARVESTD2021ZB

Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 42
• DQMHistoTests: Total histograms compared: 3250608
• DQMHistoTests: Total failures: 5
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3250580
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 41 files compared)
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 177 log files, 37 edm output root files, 42 DQM output files
• TriggerResults: no differences found

[perrotta]

type bug fix

[perrotta]

@cms-sw/reconstruction-l2 this is a simple bug fix meant to cure the broken workflow 139.002 in the IBs
Do you think it is good to merge?

[slava77]

+reconstruction

for #36428 0665009

• this enables production of MuonDigiCollection<CSCDetId,CSCShowerDigi> (optional in the CSC unpacker), which is required by L1TMuonEndCapShowerProducer
• jenkins tests pass including the run3 data workflow 139.002

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1