[DQM] DT Fixing FEDFatal

[jfernan2]

PR description:

This PR fixes DT DQM FEDFatal plot setting a Minumum number of Links/wheel with notOKFlag or TDC fatal errors to consider a FEDfatal event. The proposed threshold value by experts for such events is 15 Links/Wheel

In addtion, this PR:

• Fixes labels and filling to follow DT uROS/FED mapping
• Removes obsolete code
• Brings Online and Offline DTDataIntegirty code into one single file, for future easier maintenance, DQM/DTMonitorModule/interface/DTDataIntegrityUrosOffline.h class is not needed any longer

Some small changes in DT DQM plots are expected

PR validation:

Tested that Online DT DQM client works as expected and runTheMatrix.py -l limited works even in perLSsaving DQM mode

if this PR is a backport please specify the original PR and why you need to backport that PR:

NO backport needed

[jfernan2]

please test

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36448/27291

ERROR: Build errors found during clang-tidy run.

DQM/DTMonitorModule/src/DTDataIntegrityTask.cc:656:44: error: comparison of integers of different signs: 'unsigned int' and 'int' [clang-diagnostic-sign-compare]
    for (unsigned int iros = ros - 1; iros < abs(ros + 2); ++iros) {
                                           ^
Suppressed 1693 warnings (1692 in non-user code, 1 with check filters).
--
gmake: *** [config/SCRAM/GMake/Makefile.coderules:129: code-checks] Error 2
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2

[jfernan2]

please test

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36448/27293

• This PR adds an extra 44KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File DQM/DTMonitorModule/plugins/plugins.cc modified in PR(s): Adding modules for tag-and-probe efficiency computation in DQMOffline #36276

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36448/27293/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36448/27293/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[jfernan2]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36448/27331

• This PR adds an extra 44KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File DQM/DTMonitorModule/plugins/plugins.cc modified in PR(s): Adding modules for tag-and-probe efficiency computation in DQMOffline #36276

[cmsbuild]

Pull request #36448 was updated. @emanueleusai, @ahmad3213, @jfernan2, @rvenditti, @pbo0, @pmandrik can you please check and sign again.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9bc37f/21225/summary.html
COMMIT: 8205cb0
CMSSW: CMSSW_12_3_X_2021-12-13-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36448/21225/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 42
• DQMHistoTests: Total histograms compared: 3249714
• DQMHistoTests: Total failures: 20
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3249671
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 5.569 KiB( 41 files compared)
• DQMHistoSizes: changed ( 10824.0,... ): 3.786 KiB DT/FEDIntegrity
• DQMHistoSizes: changed ( 10824.0,... ): -3.415 KiB DT/00-DataIntegrity
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 177 log files, 37 edm output root files, 42 DQM output files
• TriggerResults: no differences found

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1