Use correct accessors for RegionalMuonShower data type

[dinyar]

PR description:

This is a cleanup PR after #36435 was used to fix #36433. Here I remove the (re)added accessors and modify both the DQM and L1TNtuple code that still used them. There should be no functional difference.

PR validation:

Ran scram build code-checks && scram build code-format, but skipped runTheMatrix.py -l limited -i all --ibeos as the code change is minor.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36455/27301

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @dinyar (Dinyar Rabady) for master.

It involves the following packages:

• DQM/L1TMonitor (dqm)
• DataFormats/L1TMuon (l1)
• L1Trigger/L1TNtuples (l1)

@epalencia, @emanueleusai, @ahmad3213, @cmsbuild, @rekovic, @jfernan2, @pmandrik, @cecilecaillol, @pbo0, @rvenditti can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @rovere, @kreczko, @thomreis this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[jfernan2]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-809883/21184/summary.html
COMMIT: 19f9c7d
CMSSW: CMSSW_12_3_X_2021-12-10-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36455/21184/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 42
• DQMHistoTests: Total histograms compared: 3250704
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3250682
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 41 files compared)
• Checked 177 log files, 37 edm output root files, 42 DQM output files
• TriggerResults: no differences found

[jfernan2]

+1

[rekovic]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1

• It follows from a discussion originally in Temporarily restore sector and endcap accessors to RegionalMuonShower #36435