Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DBOutputService: Removed deprecated methods #36490

Merged

Conversation

ggovi
Copy link
Contributor

@ggovi ggovi commented Dec 14, 2021

PR description:

The PoolDBoutputService interface (and its Derived class OnlineDBOutputService ) contains methods that have been deprecated in favour of new methods providing the same functionalities with a more explicit signature concerning the payload object ownership policy. Since all of the clients of the old interface in CMSSW have been migrated to the new interface, in this PR we proceed to remove the deprecated methods.

Replaces #36466

PR validation:

Unit and integration tests

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36490/27363

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ggovi for master.

It involves the following packages:

  • CalibMuon/DTCalibration (alca)
  • CondCore/DBOutputService (db, alca)
  • DQM/DTMonitorClient (dqm)

@malbouis, @yuanchao, @pmandrik, @emanueleusai, @ahmad3213, @tvami, @cmsbuild, @jfernan2, @ggovi, @francescobrivio, @pbo0, @rvenditti can you please review it and eventually sign? Thanks.
@mmusich, @tocheng, @battibass this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@tvami
Copy link
Contributor

tvami commented Dec 14, 2021

@cmsbuild , please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-985b58/21263/summary.html
COMMIT: 0f24a5d
CMSSW: CMSSW_12_3_X_2021-12-13-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36490/21263/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test testCondToolsSiStripBuildersReaders had ERRORS

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 42
  • DQMHistoTests: Total histograms compared: 3250704
  • DQMHistoTests: Total failures: 5
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3250676
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 41 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 177 log files, 37 edm output root files, 42 DQM output files
  • TriggerResults: no differences found

@ggovi
Copy link
Contributor Author

ggovi commented Dec 15, 2021

The above error was appearing in IBs well before this PR - It should be unrelated.

@ggovi
Copy link
Contributor Author

ggovi commented Dec 15, 2021

please test

@mmusich
Copy link
Contributor

mmusich commented Dec 15, 2021

@cmsbuild, please abort

@mmusich
Copy link
Contributor

mmusich commented Dec 15, 2021

test parameters:

@smuzaffar
Copy link
Contributor

smuzaffar commented Dec 16, 2021

yes this is due to gcc9 to gcc10. bot has been fixed to consider only the last status of the required tests

@jfernan2
Copy link
Contributor

+1

@francescobrivio
Copy link
Contributor

+alca

@tvami
Copy link
Contributor

tvami commented Dec 16, 2021

+db

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Dec 17, 2021

@ggovi since you are cleaning, I think you should remove all the places where calls to those deprecated methods remain, even if they are now commented out.

For the templated version of createNewIOV I see:

  • Alignment/CommonAlignmentProducer/plugins/GlobalTrackerMuonAlignment.cc
  • Alignment/LaserAlignment/plugins/LaserAlignment.cc
  • Alignment/TrackerAlignment/src/TrackerAlignment.cc
  • CondTools/SiStrip/plugins/SiStripPedestalsBuilder.cc

For writeOne there are several identically named methods retrieved by https://cmssdt.cern.ch/lxr/search?%21v=CMSSW_12_3_X_2021-12-15-2300&_filestring=&_string=writeOne%28&_casesensitive=1. They seem to come mostly from PoolDBOutputService.h (rather than the OnlineDBOutputService which is addressed here), but please confirm that you verified all them

@mmusich
Copy link
Contributor

mmusich commented Dec 17, 2021

@perrotta

For the templated version of createNewIOV I see:
Alignment/CommonAlignmentProducer/plugins/GlobalTrackerMuonAlignment.cc
Alignment/LaserAlignment/plugins/LaserAlignment.cc
Alignment/TrackerAlignment/src/TrackerAlignment.cc
CondTools/SiStrip/plugins/SiStripPedestalsBuilder.cc

Since I migrated all of these modules I can clean them up in a follow-up PR.

For writeOne there are several identically named methods retrieved by https://cmssdt.cern.ch/lxr/search?%21v=CMSSW_12_3_X_2021-12-15-2300&_filestring=&_string=writeOne%28&_casesensitive=1. They seem to come mostly from PoolDBOutputService.h (rather than the OnlineDBOutputService which is addressed here), but please confirm that you verified all them

None of these are coming from the DB services, they just happen to be called writeOne. In fact the packages wouldn't even compile with the the changes from Giacomo, if they were.

@mmusich
Copy link
Contributor

mmusich commented Dec 17, 2021

see #36532

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 185ca7c into cms-sw:master Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants