New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DBOutputService: Removed deprecated methods #36490
DBOutputService: Removed deprecated methods #36490
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36490/27363
|
A new Pull Request was created by @ggovi for master. It involves the following packages:
@malbouis, @yuanchao, @pmandrik, @emanueleusai, @ahmad3213, @tvami, @cmsbuild, @jfernan2, @ggovi, @francescobrivio, @pbo0, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild , please test |
-1 Failed Tests: UnitTests Unit TestsI found errors in the following unit tests: ---> test testCondToolsSiStripBuildersReaders had ERRORS Comparison SummarySummary:
|
The above error was appearing in IBs well before this PR - It should be unrelated. |
please test |
@cmsbuild, please abort |
test parameters: |
yes this is due to gcc9 to gcc10. bot has been fixed to consider only the last status of the |
+1 |
+alca |
+db |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
@ggovi since you are cleaning, I think you should remove all the places where calls to those deprecated methods remain, even if they are now commented out. For the templated version of
For |
Since I migrated all of these modules I can clean them up in a follow-up PR.
None of these are coming from the DB services, they just happen to be called |
see #36532 |
+1
|
PR description:
The PoolDBoutputService interface (and its Derived class OnlineDBOutputService ) contains methods that have been deprecated in favour of new methods providing the same functionalities with a more explicit signature concerning the payload object ownership policy. Since all of the clients of the old interface in CMSSW have been migrated to the new interface, in this PR we proceed to remove the deprecated methods.
Replaces #36466
PR validation:
Unit and integration tests