Made Tracker and Muon Geometry const

[Dr15Jones]

Made data accessible from TrackingGeometry, RPCGeometry, DTGeometry and CSCGeometry all const. This avoids thread-safety problems.

[Dr15Jones]

This incorporates #3643 and extends it to the other related geometry classes.
@VinInn

[cmsbuild]

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_1_X.

Made Tracker and Muon Geometry const

It involves the following packages:

Alignment/MuonAlignment
Alignment/OfflineValidation
Alignment/SurveyAnalysis
Alignment/TrackerAlignment
CalibFormats/SiStripObjects
CalibMuon/CSCCalibration
CalibMuon/DTCalibration
CalibTracker/SiPixelESProducers
CalibTracker/SiStripChannelGain
CalibTracker/SiStripCommon
CalibTracker/SiStripESProducers
CondFormats/SiPixelObjects
CondTools/DT
CondTools/SiPixel
CondTools/SiStrip
DPGAnalysis/Skims
DQM/DTMonitorClient
DQM/DTMonitorModule
DQM/RPCMonitorClient
DQM/RPCMonitorDigi
DQM/SiPixelMonitorCluster
DQM/SiPixelMonitorDigi
DQM/SiPixelMonitorRecHit
DQM/SiPixelMonitorTrack
DQMOffline/Muon
DataFormats/MuonDetId
EventFilter/SiPixelRawToDigi
Fireworks/Geometry
Geometry/CSCGeometry
Geometry/CommonDetUnit
Geometry/DTGeometry
Geometry/RPCGeometry
Geometry/TrackerGeometryBuilder
Geometry/TrackingGeometryAligner
L1Trigger/DTSectorCollector
L1Trigger/DTTrigger
L1Trigger/DTUtilities
L1Trigger/RPCTrigger
L1TriggerConfig/RPCTriggerConfig
RecoLocalMuon/CSCValidation
RecoLocalMuon/DTSegment
RecoLocalMuon/RPCRecHit
RecoTracker/DeDx
SimGeneral/DataMixingModule
SimMuon/CSCDigitizer
SimMuon/GEMDigitizer
SimMuon/RPCDigitizer
SimTracker/SiPixelDigitizer
SimTracker/SiStripDigitizer
SimTracker/TrackerMaterialAnalysis
TrackingTools/TrackAssociator
Validation/MuonRPCGeometry
Validation/RPCRecHits

@diguida, @ianna, @anton-a, @thspeer, @rcastello, @civanch, @ojeda, @vlimant, @cmsbuild, @ktf, @davidlange6, @Dr15Jones, @mdhildreth, @rovere, @deguio, @slava77, @ggovi, @Degano, @mulhearn, @apfeiffer1, @nclopezo, @danduggan, @alja, @franzoni can you please review it and eventually sign? Thanks.
@ghellwig, @pakhotin, @frmeier, @wmtan, @GiacomoSguazzoni, @rovere, @alja, @gpetruc, @cerati, @mmusich, @venturia this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[cmsbuild]

+1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3651/1257/summary.html

[deguio]

+1
I don't have any problem with this PR, however it is probably better to have tests and comparison run again to stay on the safe side. the jenkins summary is not accessible.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3651/1291/summary.html

[Dr15Jones]

@ktf ping?

[davidlange6]

tests all look good - merging.

[mulhearn]

+1