Drop type specs in RecoHI, RecoJets and RecoMET #36510

NiharSaha · 2021-12-15T19:21:20Z

PR description:

Drop type specs in Validation/RecoHI, Validation/RecoJets and Validation/RecoMET python configuration files.

Central DQM migration campaign for drop type spces following
https://cms-sw.github.io/cms_coding_rules.html#6--packaging-rules-1
and update the safer syntax for existing parameters like: (1) drop type specifications where the original parameter exists. (2) using "clone" instead of "deepcopy" (3) move all parameters inside the clone

PR validation:

Tested in CMSSW_12_3_X via runTheMatrix.py -l limited -i all --ibeos

cmsbuild · 2021-12-15T19:28:42Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36510/27392

This PR adds an extra 16KB to repository

cmsbuild · 2021-12-15T19:29:05Z

A new Pull Request was created by @NiharSaha (Nihar Ranjan Saha) for master.

It involves the following packages:

Validation/RecoHI (dqm)
Validation/RecoJets (dqm)
Validation/RecoMET (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please review it and eventually sign? Thanks.
@rappoccio, @ahinzmann, @kkrajczar, @mmarionncern, @jdamgov, @jdolen, @nhanvtran, @RylanC24, @schoef, @gkasieczka, @mariadalfonso, @seemasharmafnal this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

qliphy · 2021-12-16T01:27:41Z

please test

cmsbuild · 2021-12-16T09:23:05Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c568ca/21302/summary.html
COMMIT: 3c499df
CMSSW: CMSSW_12_3_X_2021-12-15-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36510/21302/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 42
DQMHistoTests: Total histograms compared: 3250719
DQMHistoTests: Total failures: 11
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 3250685
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.004 KiB( 41 files compared)
DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
Checked 177 log files, 37 edm output root files, 42 DQM output files
TriggerResults: no differences found

jfernan2 · 2021-12-16T12:26:58Z

Validation/RecoHI/python/muonValidationHeavyIons_cff.py

-
+trkMuonTrackVMuonAssocHI = MTVhi.clone(
+associatormap  = 'tpToTkMuonAssociationHI',
+label          = ['cutsRecoTrkMuons'],


I am not sure why [] was used here in the original version of the file instead of ( ) like below and the original class:

cmssw/Validation/RecoMuon/python/MuonTrackValidator_cfi.py

Line 16 in 3c499df

label = cms.VInputTag(cms.InputTag("globalMuons")),

It probably has no effect at all but we could uniform it now

I have edited from [] to () in the new commit. Thank you.

jfernan2 · 2021-12-16T12:27:08Z

Validation/RecoHI/python/muonValidationHeavyIons_cff.py

+)
+glbMuonTrackVMuonAssocHI = MTVhi.clone(
+associatormap = 'tpToGlbMuonAssociationHI',
+label           = ['globalMuons'],


Same comment as previous

cmsbuild · 2021-12-17T06:05:06Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36510/27435

This PR adds an extra 16KB to repository

cmsbuild · 2021-12-17T06:05:28Z

Pull request #36510 was updated. @emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please check and sign again.

jfernan2 · 2021-12-17T07:23:03Z

please test

cmsbuild · 2021-12-31T07:00:19Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36510/27595

This PR adds an extra 16KB to repository

cmsbuild · 2021-12-31T07:00:41Z

Pull request #36510 was updated. @emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please check and sign again.

cmsbuild · 2021-12-31T07:22:38Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36510/27596

This PR adds an extra 16KB to repository

cmsbuild · 2021-12-31T07:23:02Z

Pull request #36510 was updated. @emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please check and sign again.

perrotta · 2021-12-31T08:52:21Z

please test

cmsbuild · 2021-12-31T12:30:21Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c568ca/21507/summary.html
COMMIT: 07044d7
CMSSW: CMSSW_12_3_X_2021-12-30-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36510/21507/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 8 differences found in the comparisons
DQMHistoTests: Total files compared: 43
DQMHistoTests: Total histograms compared: 3461692
DQMHistoTests: Total failures: 10
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 3461659
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -0.004 KiB( 42 files compared)
DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
Checked 181 log files, 42 edm output root files, 43 DQM output files
TriggerResults: no differences found

jfernan2 · 2021-12-31T13:07:52Z

+1

cmsbuild · 2021-12-31T13:08:13Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

perrotta · 2021-12-31T13:15:38Z

+1

Drop type specs in RecoHI, RecoJets and RecoMET

3c499df

cmsbuild added this to the CMSSW_12_3_X milestone Dec 15, 2021

cmsbuild added code-checks-pending dqm-pending orp-pending pending-signatures tests-pending labels Dec 15, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Dec 15, 2021

cmsbuild added tests-started and removed tests-pending labels Dec 16, 2021

cmsbuild added tests-approved and removed tests-started labels Dec 16, 2021

jfernan2 reviewed Dec 16, 2021

View reviewed changes

Update muonValidationHeavyIons_cff.py

35dfffc

cmsbuild added code-checks-pending tests-pending and removed tests-approved code-checks-approved labels Dec 17, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Dec 17, 2021

cmsbuild removed the tests-pending label Dec 17, 2021

cmsbuild added dqm-pending pending-signatures tests-pending labels Dec 31, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Dec 31, 2021

Update muonValidationHeavyIons_cff.py

07044d7

cmsbuild added code-checks-pending and removed code-checks-approved labels Dec 31, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Dec 31, 2021

cmsbuild added tests-started and removed tests-pending labels Dec 31, 2021

cmsbuild added tests-approved and removed tests-started labels Dec 31, 2021

cmsbuild added dqm-approved fully-signed and removed dqm-pending pending-signatures labels Dec 31, 2021

cmsbuild added orp-approved and removed orp-pending labels Dec 31, 2021

cmsbuild merged commit fe8d9cd into cms-sw:master Dec 31, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Drop type specs in RecoHI, RecoJets and RecoMET #36510

Drop type specs in RecoHI, RecoJets and RecoMET #36510

NiharSaha commented Dec 15, 2021

cmsbuild commented Dec 15, 2021

cmsbuild commented Dec 15, 2021

qliphy commented Dec 16, 2021

cmsbuild commented Dec 16, 2021

jfernan2 Dec 16, 2021

NiharSaha Dec 16, 2021 •

edited

jfernan2 Dec 16, 2021

cmsbuild commented Dec 17, 2021

cmsbuild commented Dec 17, 2021

jfernan2 commented Dec 17, 2021

cmsbuild commented Dec 31, 2021

cmsbuild commented Dec 31, 2021

cmsbuild commented Dec 31, 2021

cmsbuild commented Dec 31, 2021

perrotta commented Dec 31, 2021

cmsbuild commented Dec 31, 2021

jfernan2 commented Dec 31, 2021

cmsbuild commented Dec 31, 2021

perrotta commented Dec 31, 2021

Drop type specs in RecoHI, RecoJets and RecoMET #36510

Drop type specs in RecoHI, RecoJets and RecoMET #36510

Conversation

NiharSaha commented Dec 15, 2021

PR description:

PR validation:

cmsbuild commented Dec 15, 2021

cmsbuild commented Dec 15, 2021

qliphy commented Dec 16, 2021

cmsbuild commented Dec 16, 2021

Comparison Summary

jfernan2 Dec 16, 2021

Choose a reason for hiding this comment

NiharSaha Dec 16, 2021 • edited

Choose a reason for hiding this comment

jfernan2 Dec 16, 2021

Choose a reason for hiding this comment

cmsbuild commented Dec 17, 2021

cmsbuild commented Dec 17, 2021

jfernan2 commented Dec 17, 2021

cmsbuild commented Dec 31, 2021

cmsbuild commented Dec 31, 2021

cmsbuild commented Dec 31, 2021

cmsbuild commented Dec 31, 2021

perrotta commented Dec 31, 2021

cmsbuild commented Dec 31, 2021

Comparison Summary

jfernan2 commented Dec 31, 2021

cmsbuild commented Dec 31, 2021

perrotta commented Dec 31, 2021

NiharSaha Dec 16, 2021 •

edited