New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First version of Payload Inspector plots for DropBoxMetadata #36520
Conversation
assign alca |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36520/27407
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
assign alca |
@@ -175,9 +217,15 @@ namespace { | |||
|
|||
l_theDisplay.printDiffWithMetadata(f_theRecordMap); | |||
|
|||
TCanvas canvas("Canv", "Canv", 1200, 100 * std::max(f_records.size(), l_records.size())); | |||
std::string fileName(this->m_imageFileName); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am afraid you need to percolate this within DBMetaDataPlotDisplay
and use it to save the result png file otherwise the PayloadInspector instance of the ConDB Browser won't be able to fetch the plot to be displayed.
@@ -107,8 +145,12 @@ namespace { | |||
DBoxMetadataHelper::DBMetaDataTableDisplay theDisplay(theRecordMap); | |||
theDisplay.printMetaDatas(); | |||
|
|||
std::string fileName(m_imageFileName); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am afraid you need to percolate this within DBMetaDataPlotDisplay
and use it to save the result png file otherwise the PayloadInspector instance of the ConDB Browser won't be able to fetch the plot to be displayed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pointing this out. I'll make the change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hope this approach works.
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36520/27444
|
New categories assigned: alca @yuanchao,@francescobrivio,@malbouis,@tvami you have been requested to review this Pull request/Issue and eventually sign? Thanks |
A new Pull Request was created by @tlampen (Tapio Lampén) for master. It involves the following packages:
@malbouis, @yuanchao, @cmsbuild, @ggovi, @francescobrivio, @tvami can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36520/27447
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
@tlampen please do code-checks, thanks! |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36520/27461
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36520/27488
|
The plots can be created with the script test_DropBoxMetadata_PayloadInspector.sh . I don't know how the plots can be saved to the unit test directory, it would indeed be useful to have them there. |
@cmsbuild please test |
in principle this unit test:
produces plots both in IBs and PR tests, though I think the bot is setup to ignore anything else which is not log. |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5436d8/21400/summary.html Comparison SummarySummary:
|
+1
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR introduces new plots for the Payload Inspector for the class DropBoxMetadata as well as a script for testing. These plots can 1) display content of a DropBoxMetadata tag, 2) compare two IOVs of one tag, and 3) compare two tags. Examples of the plots are attached.
This PR continues from the infrastructural changes introduced in #35956 . This PR however does not fully exploit the new intrastructure, since it is useful to quickly make these new tools available.
HLTPlugins/plugins/AlCaRecoTriggerBits_PayloadInspector.cc was used as a source of inspiration for this work.
DropBoxMetadata is describe in this TWiki page: https://twiki.cern.ch/twiki/bin/view/CMS/ConditionUploader#Metadata_file .
PR validation:
PR passes the introduced test.
if this PR is a backport please specify the original PR and why you need to backport that PR:
No backport foreseen.