Safer syntax for modifying the configuration parameters in g4SimHits_cfi.py

[perrotta]

In #36506 some partial migration to a safer syntax for modifying the configuration parameters in g4SimHits_cfi.py was started, which avoids overwriting types of those parameters or mis-naming them.

In order not to let the work half done, here are the remaining updates for the other non-migrated parameter updates in the same config

PR validation:

The short matrix runs without error.
Unless I made some trivial mistake in it, no changes are expected anywhere in the test outputs.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36524/27413

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @perrotta (Andrea Perrotta) for master.

It involves the following packages:

• SimG4Core/Application (simulation)

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel, @cvuosalo, @rovere, @bsunanda, @fabiocos, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[perrotta]

please test

[bsunanda]

Why do you change TimeSliceUnit = 0.00 shouldn't it be TimeSliceUnit = 0.001

[perrotta]

Why do you change TimeSliceUnit = 0.00 shouldn't it be TimeSliceUnit = 0.001

Thank you Sunanda: this is exactly what I meant for "trivial mistake" in the PR description...

[perrotta]

please abort

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36524/27415

• This PR adds an extra 16KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File SimG4Core/Application/python/g4SimHits_cfi.py modified in PR(s): Remove Event Interpretation (EI) from relval steps #36465

[perrotta]

please test

[cmsbuild]

Pull request #36524 was updated. @cmsbuild, @civanch, @mdhildreth can you please check and sign again.

[civanch]

@perrotta , thanks, I was not sure that you are on-line, so make extra PR - it will be closed.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36524/27466

• This PR adds an extra 16KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File SimG4Core/Application/python/g4SimHits_cfi.py modified in PR(s): Disable LHC transport #36545

[cmsbuild]

Pull request #36524 was updated. @cmsbuild, @civanch, @mdhildreth can you please check and sign again.

[perrotta]

please test

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1

• Let have it merged before the 1100 IB, and see if the instabilities reported in Instabilities in 11634.911 (DD4Hep) workflow comparisons #35109 disappear in test starting from tomorrow
• @cms-sw/ctpps-dpg-l2 please take note that LHC transport has been temporarily disabled here: it will be re-enabled once issue Thread-safety issue in TotemTransport #36544 will have a solution

[perrotta]

merge

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-277c1c/21373/summary.html
COMMIT: 45ef8d9
CMSSW: CMSSW_12_3_X_2021-12-17-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36524/21373/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 14125 differences found in the comparisons
• DQMHistoTests: Total files compared: 42
• DQMHistoTests: Total histograms compared: 3250719
• DQMHistoTests: Total failures: 17241
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3233456
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 41 files compared)
• Checked 177 log files, 37 edm output root files, 42 DQM output files
• TriggerResults: found differences in 5 / 41 workflows