Remove MallocOpts as obsolete #36530

makortel · 2021-12-16T21:28:50Z

PR description:

Resolves #36500

PR validation:

Framework unit tests run

cmsbuild · 2021-12-16T21:35:25Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36530/27429

This PR adds an extra 28KB to repository

cmsbuild · 2021-12-16T21:35:47Z

A new Pull Request was created by @makortel (Matti Kortelainen) for master.

It involves the following packages:

FWCore/Services (core)
FWCore/Utilities (core)

@cmsbuild, @smuzaffar, @Dr15Jones, @makortel can you please review it and eventually sign? Thanks.
@felicepantaleo, @wddgit this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

makortel · 2021-12-16T21:37:59Z

@cmsbuild, please test

makortel · 2021-12-16T21:38:07Z

@Dr15Jones Do you agree?

Dr15Jones · 2021-12-16T21:50:52Z

Do you agree?

yes.

cmsbuild · 2021-12-17T01:09:26Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d2b6e7/21337/summary.html
COMMIT: ab1846c
CMSSW: CMSSW_12_3_X_2021-12-16-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36530/21337/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 8493 differences found in the comparisons
DQMHistoTests: Total files compared: 42
DQMHistoTests: Total histograms compared: 3250719
DQMHistoTests: Total failures: 10246
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3240451
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 41 files compared)
Checked 177 log files, 37 edm output root files, 42 DQM output files
TriggerResults: found differences in 3 / 41 workflows

makortel · 2021-12-17T14:40:36Z

@cmsbuild, please test

cmsbuild · 2021-12-17T18:10:45Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d2b6e7/21359/summary.html
COMMIT: ab1846c
CMSSW: CMSSW_12_3_X_2021-12-17-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36530/21359/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 5780 differences found in the comparisons
DQMHistoTests: Total files compared: 42
DQMHistoTests: Total histograms compared: 3250719
DQMHistoTests: Total failures: 5488
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3245209
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 41 files compared)
Checked 177 log files, 37 edm output root files, 42 DQM output files
TriggerResults: found differences in 2 / 41 workflows

makortel · 2021-12-17T18:18:22Z

@cmsbuild, please test

cmsbuild · 2021-12-17T21:40:19Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d2b6e7/21368/summary.html
COMMIT: ab1846c
CMSSW: CMSSW_12_3_X_2021-12-17-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36530/21368/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 14277 differences found in the comparisons
DQMHistoTests: Total files compared: 42
DQMHistoTests: Total histograms compared: 3250719
DQMHistoTests: Total failures: 15735
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3234962
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 41 files compared)
Checked 177 log files, 37 edm output root files, 42 DQM output files
TriggerResults: found differences in 5 / 41 workflows

perrotta · 2021-12-18T07:30:25Z

please test
(just to check whether in the new IB the differences in 11634.X workflows do disappear)

cmsbuild · 2021-12-18T11:11:53Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d2b6e7/21381/summary.html
COMMIT: ab1846c
CMSSW: CMSSW_12_3_X_2021-12-17-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36530/21381/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 2 differences found in the comparisons
DQMHistoTests: Total files compared: 43
DQMHistoTests: Total histograms compared: 3459395
DQMHistoTests: Total failures: 6
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3459367
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 42 files compared)
Checked 181 log files, 42 edm output root files, 43 DQM output files
TriggerResults: no differences found

makortel · 2021-12-20T02:04:55Z

@cmsbuild, please test

makortel · 2021-12-20T02:06:48Z

(apparently I'm testing "just for fun"...)

makortel · 2021-12-20T02:06:53Z

+1

cmsbuild · 2021-12-20T02:07:11Z

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

cmsbuild · 2021-12-20T05:42:48Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d2b6e7/21397/summary.html
COMMIT: ab1846c
CMSSW: CMSSW_12_3_X_2021-12-19-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36530/21397/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 43
DQMHistoTests: Total histograms compared: 3461688
DQMHistoTests: Total failures: 0
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3461666
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 42 files compared)
Checked 181 log files, 42 edm output root files, 43 DQM output files
TriggerResults: no differences found

perrotta · 2021-12-20T07:58:16Z

+1

Remove MallocOpts as obsolete

ab1846c

cmsbuild added this to the CMSSW_12_3_X milestone Dec 16, 2021

cmsbuild added code-checks-pending core-pending orp-pending pending-signatures tests-pending labels Dec 16, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Dec 16, 2021

cmsbuild added tests-started and removed tests-pending labels Dec 16, 2021

cmsbuild added tests-approved and removed tests-started labels Dec 17, 2021

makortel mentioned this pull request Dec 17, 2021

Instabilities in 11634.911 (DD4Hep) workflow comparisons #35109

Open

cmsbuild added tests-started and removed tests-approved labels Dec 17, 2021

cmsbuild added tests-approved and removed tests-started labels Dec 17, 2021

cmsbuild added tests-started and removed tests-approved labels Dec 17, 2021

cmsbuild added tests-approved and removed tests-started labels Dec 17, 2021

cmsbuild added tests-started and removed tests-approved labels Dec 18, 2021

cmsbuild added tests-approved and removed tests-started labels Dec 18, 2021

cmsbuild added tests-started and removed tests-approved labels Dec 20, 2021

cmsbuild added core-approved fully-signed and removed core-pending pending-signatures labels Dec 20, 2021

cmsbuild added tests-approved and removed tests-started labels Dec 20, 2021

cmsbuild added orp-approved and removed orp-pending labels Dec 20, 2021

cmsbuild merged commit 498a491 into cms-sw:master Dec 20, 2021

makortel deleted the removeMallocOpts branch December 20, 2021 17:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove MallocOpts as obsolete #36530

Remove MallocOpts as obsolete #36530

makortel commented Dec 16, 2021

cmsbuild commented Dec 16, 2021

cmsbuild commented Dec 16, 2021

makortel commented Dec 16, 2021

makortel commented Dec 16, 2021

Dr15Jones commented Dec 16, 2021

cmsbuild commented Dec 17, 2021

makortel commented Dec 17, 2021

cmsbuild commented Dec 17, 2021

makortel commented Dec 17, 2021

cmsbuild commented Dec 17, 2021

perrotta commented Dec 18, 2021

cmsbuild commented Dec 18, 2021

makortel commented Dec 20, 2021

makortel commented Dec 20, 2021

makortel commented Dec 20, 2021

cmsbuild commented Dec 20, 2021

cmsbuild commented Dec 20, 2021

perrotta commented Dec 20, 2021

Remove MallocOpts as obsolete #36530

Remove MallocOpts as obsolete #36530

Conversation

makortel commented Dec 16, 2021

PR description:

PR validation:

cmsbuild commented Dec 16, 2021

cmsbuild commented Dec 16, 2021

makortel commented Dec 16, 2021

makortel commented Dec 16, 2021

Dr15Jones commented Dec 16, 2021

cmsbuild commented Dec 17, 2021

Comparison Summary

makortel commented Dec 17, 2021

cmsbuild commented Dec 17, 2021

Comparison Summary

makortel commented Dec 17, 2021

cmsbuild commented Dec 17, 2021

Comparison Summary

perrotta commented Dec 18, 2021

cmsbuild commented Dec 18, 2021

Comparison Summary

makortel commented Dec 20, 2021

makortel commented Dec 20, 2021

makortel commented Dec 20, 2021

cmsbuild commented Dec 20, 2021

cmsbuild commented Dec 20, 2021

Comparison Summary

perrotta commented Dec 20, 2021