Fix for DTMapGenerator and cleanup for DTTTrigCorrectionFirst (in CalibMuon/DTCalibration)

[perrotta]

PR description:

Dead assignment reports of the static analyzer pointed out at something which looks like a bug (with a rather obvious fix) in the endJob() methid of CalibMuon/DTCalibration/plugins/DTMapGenerator.cc.
Perhaps @battibass can confirm

Another dead assignment in CalibMuon/DTCalibration/plugins/DTTTrigCorrectionFirst.cc can be fixed simply by removing the useless code.

PR validation:

Code builds

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36534/27438

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @perrotta (Andrea Perrotta) for master.

It involves the following packages:

• CalibMuon/DTCalibration (alca)

@cmsbuild, @malbouis, @tvami, @yuanchao, @francescobrivio can you please review it and eventually sign? Thanks.
@mmusich, @tocheng, @battibass this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[perrotta]

please test

[perrotta]

This is the actual bugfix: otherwise outRob assignments above get overwritten

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-df3687/21356/summary.html
COMMIT: 3a9deef
CMSSW: CMSSW_12_3_X_2021-12-16-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36534/21356/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 2783 differences found in the comparisons
• DQMHistoTests: Total files compared: 42
• DQMHistoTests: Total histograms compared: 3250719
• DQMHistoTests: Total failures: 3832
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3246865
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 41 files compared)
• Checked 177 log files, 37 edm output root files, 42 DQM output files
• TriggerResults: found differences in 1 / 41 workflows

[tvami]

+alca

• bugfix
• test diffs are coming from different (known) sources

[tvami]

type bug-fix

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1