Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebase fast merger pb #3656

Merged
merged 6 commits into from May 4, 2014
Merged

Rebase fast merger pb #3656

merged 6 commits into from May 4, 2014

Conversation

deguio
Copy link
Contributor

@deguio deguio commented May 3, 2014

this PR includes the following new feature needed for the Online DQM:

  • Fast ROOT file format based on Protocol Buffer
    the changes shouldn't interfere in any way with the DQMStore/DQMFileSaver functionalities.

rovere and others added 5 commits April 30, 2014 17:10
…e format.

Use Protocol Buffer from CMSSW Release

Minor stylistic fixes

Add conversion option from PB to ROOT format

Minor stylistic fixes

Enable reading PB files into DQMStore

Unit Test to check both ROOT and PB merging and timing

Improve tests on fasthadd

Add showusage() help message.

Add encoding from ROOT to PB format

Simplified the logic of the parallel algorithm

Properly delete histograms after usage

Speed-up of testing phase and make it compatible with Python2.4 to be able to build on SLC5
@cmsbuild
Copy link
Contributor

cmsbuild commented May 3, 2014

A new Pull Request was created by @deguio for CMSSW_7_1_X.

Rebase fast merger pb

It involves the following packages:

DQMServices/Components
DQMServices/Core

@ojeda, @danduggan, @rovere, @cmsbuild, @nclopezo, @deguio, @Degano can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 3, 2014

Pull request #3656 was updated. @ojeda, @danduggan, @rovere, @cmsbuild, @nclopezo, @deguio, @Degano can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 3, 2014

@cmsbuild
Copy link
Contributor

cmsbuild commented May 3, 2014

@deguio
Copy link
Contributor Author

deguio commented May 4, 2014

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

ktf added a commit that referenced this pull request May 4, 2014
@ktf ktf merged commit 25ac478 into cms-sw:CMSSW_7_1_X May 4, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants