Initialize variables, and a few other trivial adjustments in RecoRomanPot/RecoFP420

[perrotta]

PR description:

I understand that this code is not currently used in CMSSW. Anyhow, it was rather annoying to see Static Analyzer warnings coming from it: a few missing initializations were added in order to (hopefully) cope with them.

While doing so, I also profited to fix some rather obvious bad coding that I encountered: this cleaning is not supposed, nor meant, to be complete, as I just touched what jumped under my eyes.

Overall, no changes are expected if and when this code will be ever used.

PR validation:

It builds

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36618/27608

• This PR adds an extra 24KB to repository

[cmsbuild]

A new Pull Request was created by @perrotta (Andrea Perrotta) for master.

It involves the following packages:

• RecoRomanPot/RecoFP420 (reconstruction)

@jpata, @cmsbuild, @clacaputo, @slava77 can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[perrotta]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16b3f6/21509/summary.html
COMMIT: 502846c
CMSSW: CMSSW_12_3_X_2021-12-31-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36618/21509/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 43
• DQMHistoTests: Total histograms compared: 3461692
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3461664
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 42 files compared)
• Checked 181 log files, 42 edm output root files, 43 DQM output files
• TriggerResults: no differences found

[jpata]

Thanks for this! I think we should investigate if this outdated code can be dropped, if there is no way to test it, and nobody really monitoring the outputs.

[jpata]

+reconstruction

• signing this as a minimal/technical change, but the code is not running or tested (review current use cases of RecoFP420 #36612)

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1