Phase2 tracker: add T30 (geometry with more realistic TFPX) #36660

adewit · 2022-01-10T10:34:20Z

PR description:

This adds a new Phase 2 tracker geometry (T30). It is similar to T21/T24, with the main changes occurring in TFPX and TEPX, and a minor change in the OT (updated TB2S module spacing). All sensors in the IT are 25x100 um2 planar

The changes in TFPX and TEPX are:

More realistic TFPX module placement (global shift in z positions of the disks, increase in dphi between the modules around ±90 degrees, small rotation of modules around global z axis, dependent on the module position)
Re-ordering of the module placement on the dees in TFPX

As a consequence of the last point, a new hierarchy level (subdisk) has been introduced for the forward pixel to address issues observed in the tracking (not all hits from one TP entering the same track, leading to a high prevalence of additional tracks with only a few hits). This new hierarchy level required the addition of a new detID schema, which is used both in TFPX and TEPX, where the same approach is useful.

More information, and validation of these changes, can be found in these slides, where T30 is labelled TX1.

Note: the new hierarchy level, and associated further changes to the code, is only used in T30 for the moment. All other tracker geometries use the already existing phase 2 detID schema and are not affected by the changes implemented here.

@emiglior FYI

PR validation:

Checked runTheMatrix workflows run without errors (including workflows not using the new detID schema)
Checked position of the modules matches that expected in the mechanical design
Analysis of tracking validation plots and other diagnostic tests as detailed here

if this PR is a backport please specify the original PR and why you need to backport that PR:

Not a backport

cmsbuild · 2022-01-10T10:40:00Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36660/27695

This PR adds an extra 292KB to repository
Found files with invalid states:
- Geometry/CMSCommonData/data/dd4hep/GeometryDD4hepExtended2026D82_cff.py:
  - Added: e353b56
  - Deleted: 8507dfd
- Geometry/CMSCommonData/data/dd4hep/GeometryDD4hepExtended2026D82Reco_cff.py:
  - Added: e353b56
  - Deleted: 8507dfd
There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py modified in PR(s): Phase 2 HLT menu targetting 7.5×10³⁴ cm⁻²s⁻¹ #35342, Add run3 tracking low pu era #33532, Remove Event Interpretation (EI) from relval steps #36465, HGCAL Pattern Recognition using FastJet #36172

cmsbuild · 2022-01-10T10:40:24Z

A new Pull Request was created by @adewit for master.

It involves the following packages:

Configuration/AlCa (alca)
Configuration/Geometry (geometry, upgrade)
Configuration/PyReleaseValidation (pdmv, upgrade)
Configuration/StandardSequences (operations)
Geometry/CMSCommonData (geometry, upgrade)
Geometry/TrackerCommonData (geometry)
Geometry/TrackerNumberingBuilder (geometry)
Geometry/TrackerRecoData (geometry)
Geometry/TrackerSimData (geometry)
L1Trigger/TrackerDTC (upgrade, l1)
RecoTracker/TkDetLayers (reconstruction)

@bbilin, @wajidalikhan, @ianna, @rekovic, @cecilecaillol, @perrotta, @civanch, @yuanchao, @makortel, @cmsbuild, @davidlange6, @Dr15Jones, @epalencia, @cvuosalo, @mdhildreth, @AdrianoDee, @kskovpen, @slava77, @jpata, @qliphy, @fabiocos, @francescobrivio, @malbouis, @jordan-martins, @clacaputo, @srimanob, @tvami can you please review it and eventually sign? Thanks.
@erikbutz, @felicepantaleo, @kpedro88, @ghugo83, @Martin-Grunewald, @bsunanda, @mmusich, @slomeo, @venturia, @vargasa, @makortel, @JanFSchulte, @dgulhan, @missirol, @skinnari, @GiacomoSguazzoni, @rovere, @VinInn, @tocheng, @ebrondol, @mtosi, @fabiocos, @lecriste, @gpetruc this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

yuanchao · 2022-01-10T11:27:20Z

@cmsbuild please test

cmsbuild · 2022-01-10T15:13:42Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d44be8/21591/summary.html
COMMIT: e051c9c
CMSSW: CMSSW_12_3_X_2022-01-09-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36660/21591/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 8 differences found in the comparisons
DQMHistoTests: Total files compared: 43
DQMHistoTests: Total histograms compared: 3461659
DQMHistoTests: Total failures: 11
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3461626
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 42 files compared)
Checked 181 log files, 42 edm output root files, 43 DQM output files
TriggerResults: no differences found

mmusich · 2022-01-11T10:39:10Z

test parameters:

workflow = 40634.0

mmusich · 2022-01-11T10:39:20Z

@cmsbuild, please test

jpata · 2022-01-11T11:52:47Z

It looks like a lot of the new code is a copy (with some modifications) of existing code. In general, this can be a maintenance issue. Has this been already discussed (and agreed) in @cms-sw/tracking-pog-l2 and other groups if this is the desired way forward?

cmsbuild · 2022-01-11T14:21:05Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d44be8/21620/summary.html
COMMIT: e051c9c
CMSSW: CMSSW_12_3_X_2022-01-10-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36660/21620/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-d44be8/40634.0_TTbar_14TeV+2026D91+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 43
DQMHistoTests: Total histograms compared: 3461659
DQMHistoTests: Total failures: 0
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3461637
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 42 files compared)
Checked 181 log files, 42 edm output root files, 43 DQM output files
TriggerResults: no differences found

mmusich · 2022-02-10T09:58:03Z

urgent

mmusich · 2022-02-10T09:58:27Z

@cms-sw/upgrade-l2 @cms-sw/pdmv-l2 @cms-sw/operations-l2 ping

kskovpen · 2022-02-10T10:01:14Z

+pdmv

srimanob · 2022-02-10T10:09:50Z

Hi,
Don't you need to rebase, i.e.

mmusich · 2022-02-10T10:14:29Z

Don't you need to rebase, i.e.

gitHub says no.
@srimanob can you clarify?

kpedro88 · 2022-02-10T14:00:56Z

as long as the changes to a file aren't on the same or neighboring lines, git can figure out how to combine them.

mmusich · 2022-02-10T14:17:25Z

as long as the changes to a file aren't on the same or neighboring lines, git can figure out how to combine them.

So, it can be signed, no?

srimanob · 2022-02-10T14:28:06Z

Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py

+        'Geom' : 'Extended2026D91',
+        'HLTmenu': '@fake2',
+        'GT' : 'auto:phase2_realistic_T30',
+        'Era' : 'Phase2C11I13M9',


The era is not done properly here. D91 uses C17, so the era should be Phase2C17I13M9. https://github.com/cms-sw/cmssw/blob/master/Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py#L1583-L1589

I've addressed the comment here: #36931.
BTW @adewit the new D91 geometry is not documented in https://github.com/cms-sw/cmssw/blob/master/Configuration/Geometry/README.md, is it intended?

Thanks @mmusich - the lack of documentation is not intentional. Can we add it in #36931?

In the list of tracker versions:
T30: Phase2 tilted tracker, exploratory geometry *only to be used in D91 for now*. Outer Tracker (v8.0.1): based on v8.0.0 with updated TB2S spacing. Inner Tracker (v6.4.0): based on v6.1.5 but TFPX with more realistic module positions

And at the end of the list of geometries:
D91 = T30+C17+M10+I15+O9+F6

sure. Done in 2ae9367

srimanob · 2022-02-10T14:29:02Z

I've only a comment in Era, but if you would like to merge, then fix in the small PR, I am fine too.

adewit · 2022-02-10T14:42:46Z

I've only a comment in Era, but if you would like to merge, then fix in the small PR, I am fine too.

@srimanob It is probably more efficient to send a second PR to fix this small issue. I'll do it as soon as this PR is merged.

AdrianoDee · 2022-02-10T14:48:17Z

+Upgrade
(minor comment suggested by @srimanob may be addressed in a follow-up PR)

qliphy · 2022-02-11T01:46:16Z

+1
to be included in 12_3_0_pre5 next week
comment to be addressed in a separate PR

cmsbuild · 2022-02-11T01:46:38Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

cmsbuild added this to the CMSSW_12_3_X milestone Jan 10, 2022

cmsbuild added alca-pending code-checks-pending geometry-pending l1-pending operations-pending orp-pending pdmv-pending pending-signatures reconstruction-pending tests-pending upgrade-pending labels Jan 10, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Jan 10, 2022

cmsbuild added tests-started and removed tests-pending labels Jan 10, 2022

cmsbuild added tests-approved and removed tests-started labels Jan 10, 2022

cmsbuild added tests-started and removed tests-approved labels Jan 11, 2022

cmsbuild added tests-approved and removed tests-started labels Jan 11, 2022

cmsbuild added the urgent label Feb 10, 2022

cmsbuild added pdmv-approved and removed pdmv-pending labels Feb 10, 2022

srimanob reviewed Feb 10, 2022

View reviewed changes

cmsbuild added upgrade-approved and removed upgrade-pending labels Feb 10, 2022

cmsbuild added fully-signed operations-approved orp-approved and removed operations-pending pending-signatures orp-pending labels Feb 11, 2022

cmsbuild merged commit 09bb0b7 into cms-sw:master Feb 11, 2022

mmusich mentioned this pull request Feb 11, 2022

fix era to be compliant with underlying D91 geometry #36931

Merged

This was referenced Feb 11, 2022

update the MLPF model cms-data/RecoParticleFlow-PFProducer#3

Merged

[HGCAL trigger] Migration to new code structure - First pass #36337

Merged

BeamSpot + Rho variables in nanoAODs #36037

Merged

Raffaella07 mentioned this pull request Apr 17, 2024

Adding Phase2 tracker T36, T37 and T38 (for IT studies) #44765

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Phase2 tracker: add T30 (geometry with more realistic TFPX) #36660

Phase2 tracker: add T30 (geometry with more realistic TFPX) #36660

adewit commented Jan 10, 2022 •

edited

cmsbuild commented Jan 10, 2022

cmsbuild commented Jan 10, 2022

yuanchao commented Jan 10, 2022

cmsbuild commented Jan 10, 2022

mmusich commented Jan 11, 2022

mmusich commented Jan 11, 2022

jpata commented Jan 11, 2022

cmsbuild commented Jan 11, 2022

mmusich commented Feb 10, 2022

mmusich commented Feb 10, 2022

kskovpen commented Feb 10, 2022

srimanob commented Feb 10, 2022 •

edited

mmusich commented Feb 10, 2022 •

edited

kpedro88 commented Feb 10, 2022 •

edited

mmusich commented Feb 10, 2022

srimanob Feb 10, 2022

mmusich Feb 11, 2022

adewit Feb 11, 2022

mmusich Feb 11, 2022

srimanob commented Feb 10, 2022

adewit commented Feb 10, 2022

AdrianoDee commented Feb 10, 2022

qliphy commented Feb 11, 2022

cmsbuild commented Feb 11, 2022

Phase2 tracker: add T30 (geometry with more realistic TFPX) #36660

Phase2 tracker: add T30 (geometry with more realistic TFPX) #36660

Conversation

adewit commented Jan 10, 2022 • edited

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented Jan 10, 2022

cmsbuild commented Jan 10, 2022

yuanchao commented Jan 10, 2022

cmsbuild commented Jan 10, 2022

Comparison Summary

mmusich commented Jan 11, 2022

mmusich commented Jan 11, 2022

jpata commented Jan 11, 2022

cmsbuild commented Jan 11, 2022

Comparison Summary

mmusich commented Feb 10, 2022

mmusich commented Feb 10, 2022

kskovpen commented Feb 10, 2022

srimanob commented Feb 10, 2022 • edited

mmusich commented Feb 10, 2022 • edited

kpedro88 commented Feb 10, 2022 • edited

mmusich commented Feb 10, 2022

srimanob Feb 10, 2022

Choose a reason for hiding this comment

mmusich Feb 11, 2022

Choose a reason for hiding this comment

adewit Feb 11, 2022

Choose a reason for hiding this comment

mmusich Feb 11, 2022

Choose a reason for hiding this comment

srimanob commented Feb 10, 2022

adewit commented Feb 10, 2022

AdrianoDee commented Feb 10, 2022

qliphy commented Feb 11, 2022

cmsbuild commented Feb 11, 2022

adewit commented Jan 10, 2022 •

edited

srimanob commented Feb 10, 2022 •

edited

mmusich commented Feb 10, 2022 •

edited

kpedro88 commented Feb 10, 2022 •

edited