Enable PPS transport

[civanch]

PR description:

Attempt to enable PPS proton transport

PR validation:

private

if this PR is a backport please specify the original PR and why you need to backport that PR: NO

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36718/27810

• This PR adds an extra 16KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File SimG4Core/Application/python/g4SimHits_cfi.py modified in PR(s): Updated Exceptions for SIM step #36717

[cmsbuild]

A new Pull Request was created by @civanch (Vladimir Ivantchenko) for master.

It involves the following packages:

• SimG4Core/Application (simulation)

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel, @cvuosalo, @rovere, @bsunanda, @fabiocos, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[civanch]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-021923/21745/summary.html
COMMIT: ac93671
CMSSW: CMSSW_12_3_X_2022-01-16-0000/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36718/21745/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 17588 differences found in the comparisons
• DQMHistoTests: Total files compared: 43
• DQMHistoTests: Total histograms compared: 3464734
• DQMHistoTests: Total failures: 77601
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3387110
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 1.0 KiB( 42 files compared)
• DQMHistoSizes: changed ( 11834.0 ): 0.996 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 181 log files, 42 edm output root files, 43 DQM output files
• TriggerResults: found differences in 6 / 42 workflows

[civanch]

@mundim , please, check this PR - this is an attempt to enable PPS simulation again.

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[mundim]

@mundim , please, check this PR - this is an attempt to enable PPS simulation again.

Hi Vladimir. Sorry to have nor replied you directly. I have done some tests with Gustavo Gil (@diemort ?) and the simulation is working properly, but I'm not 100% sure I have tests specifically this PR. I mentioning Gustavo here, hopefully he can reply you. I'm no longer in the PPS simulation group, but could give some help in case it is needed.

[perrotta]

+1

• As agreed right now at the ORP meeting, let enable PPS Transport in the master IBs and verify as such if the fix implemented long time ago to solve the thread issues actually works

[perrotta]

@mundim , please, check this PR - this is an attempt to enable PPS simulation again.

Hi Vladimir. Sorry to have nor replied you directly. I have done some tests with Gustavo Gil (@diemort ?) and the simulation is working properly, but I'm not 100% sure I have tests specifically this PR. I mentioning Gustavo here, hopefully he can reply you. I'm no longer in the PPS simulation group, but could give some help in case it is needed.

@mundim thank you for your message. It crossed the decision taken at the ORP to test it in the release.
Since the switch is now merged, let have a look whether the non-reproducibility issues show up again in the next IB.

[mundim]

The tests I have done last week was in fact to check the thread safety issue and it was cured... I'll see with @diemort if he needs help to test this issue. Thank you.

[diemort]

dear all, I tested the flag in the last night IB and it works as expected: without any flag the CTPPS simulation is active and it is skipped by setting manually the flag to False. So, this change is good from my side.