Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get rid of deprecation warnings from RecoVertex subsystem #36789

Merged

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Jan 24, 2022

PR description:

Trivial PR, title says it all.
Part of the migration in #36404.
Went systematically through all of the CMSDEPRECATED_X warnings in the RecoVertex subsystem from CMSSW_12_3_CMSDEPRECATED_X_2022-01-21-2300 and removed deprecated API calls.

PR validation:

cmssw compiles

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36789/27930

  • This PR adds an extra 24KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

  • RecoVertex/AdaptiveVertexFinder (reconstruction)
  • RecoVertex/ConfigurableVertexReco (reconstruction)
  • RecoVertex/GaussianSumVertexFit (reconstruction)
  • RecoVertex/KinematicFit (reconstruction)
  • RecoVertex/PrimaryVertexProducer (reconstruction)

@jpata, @cmsbuild, @clacaputo, @slava77 can you please review it and eventually sign? Thanks.
@AlexDeMoor, @emilbols, @andrzejnovak, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @JyothsnaKomaragiri, @mmusich, @demuller, @mtosi, @dgulhan this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Jan 25, 2022

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a4654c/21979/summary.html
COMMIT: 2486278
CMSSW: CMSSW_12_3_X_2022-01-24-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36789/21979/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 43
  • DQMHistoTests: Total histograms compared: 3449324
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3449302
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 42 files compared)
  • Checked 181 log files, 42 edm output root files, 43 DQM output files
  • TriggerResults: no differences found

Copy link
Contributor

@clacaputo clacaputo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please move to cms::Exception in the following EDAnalyzer? Also, there are a few cout that can be changed to edm::LogPrint

  • GsfTest
  • TrackMix
  • KineExample

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36789/27974

  • This PR adds an extra 24KB to repository

@cmsbuild
Copy link
Contributor

Pull request #36789 was updated. @jpata, @cmsbuild, @clacaputo, @slava77 can you please check and sign again.

@mmusich
Copy link
Contributor Author

mmusich commented Jan 27, 2022

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a4654c/22039/summary.html
COMMIT: a3d0ed7
CMSSW: CMSSW_12_3_X_2022-01-26-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36789/22039/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 1 differences found in the comparisons
  • DQMHistoTests: Total files compared: 43
  • DQMHistoTests: Total histograms compared: 3449324
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3449302
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 42 files compared)
  • Checked 181 log files, 42 edm output root files, 43 DQM output files
  • TriggerResults: no differences found

@clacaputo
Copy link
Contributor

+reconstruction

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 3dd657a into cms-sw:master Jan 27, 2022
@mmusich mmusich deleted the getRidOfDeprecationWarningsRecoVertex branch January 27, 2022 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants