New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
get rid of deprecation warnings from RecoVertex
subsystem
#36789
get rid of deprecation warnings from RecoVertex
subsystem
#36789
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36789/27930
|
A new Pull Request was created by @mmusich (Marco Musich) for master. It involves the following packages:
@jpata, @cmsbuild, @clacaputo, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a4654c/21979/summary.html Comparison SummarySummary:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please move to cms::Exception
in the following EDAnalyzer
? Also, there are a few cout
that can be changed to edm::LogPrint
GsfTest
TrackMix
KineExample
2486278
to
a3d0ed7
Compare
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36789/27974
|
Pull request #36789 was updated. @jpata, @cmsbuild, @clacaputo, @slava77 can you please check and sign again. |
@cmsbuild, please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a4654c/22039/summary.html Comparison SummarySummary:
|
+reconstruction
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Trivial PR, title says it all.
Part of the migration in #36404.
Went systematically through all of the
CMSDEPRECATED_X
warnings in theRecoVertex
subsystem fromCMSSW_12_3_CMSDEPRECATED_X_2022-01-21-2300
and removed deprecated API calls.PR validation:
cmssw
compilesif this PR is a backport please specify the original PR and why you need to backport that PR:
N/A