Add HLTDoubletSinglet filter

[mbluj]

PR description:

This PR adds class template HLTDoubleSinglet<T1,T2,T3> which, looking at three collections col1<T1>, col2<T2> and col3<T3>, filters events where there are no objects in col3 unmatched with an object from col1 and another (different) object from col2. In other words, it selects events containing triplets of different objects from col1, col2 and col3 which form two pairs with a common element (1,3) and (2,3). Collections col1, col2 and col3 could be the same or different collections, and types of objects in the collections can be same or different.

Using this template class a filter called HLT3DoubletPFTauPFJet is defined using col1=col2=col<PFTau> and col3<PFJet> which it will be used in a newly developed DoublePFTau+PFJet HLT path.

[mbluj]

@jaimeleonh FYI

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36828/27993

• This PR adds an extra 20KB to repository

• Found files with invalid states:

  • HLTrigger/HLTfilters/plugins/HLTDoubleSinglet.cc:
    • Added: e11a3e8
    • Modified: 57c378a
    • Deleted: e913bf7
  • HLTrigger/HLTfilters/plugins/HLTDoubleSinglet.h:
    • Added: e11a3e8
    • Modified: 57c378a
    • Deleted: e913bf7

[cmsbuild]

A new Pull Request was created by @mbluj for master.

It involves the following packages:

• HLTrigger/HLTfilters (hlt)

@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @silviodonato this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[missirol]

Here's a review of these updates. I see that the new plugin closely follows other ones in this package (for example HLTDoublet, for example), but I have some questions to understand things better.

@Martin-Grunewald knows this type of plugins better than I do, so, if needed, he can correct me or clarify what the better implementation is.

[mbluj]

@missirol I have just committed code implementing most of your comments. Rest should be available later.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36828/28051

• This PR adds an extra 20KB to repository

• Found files with invalid states:

  • HLTrigger/HLTfilters/plugins/HLTDoubleSinglet.cc:
    • Added: e11a3e8
    • Modified: 57c378a
    • Deleted: e913bf7
  • HLTrigger/HLTfilters/plugins/HLTDoubleSinglet.h:
    • Added: e11a3e8
    • Modified: 57c378a
    • Deleted: e913bf7

[cmsbuild]

Pull request #36828 was updated. @cmsbuild, @missirol, @Martin-Grunewald can you please check and sign again.

[mbluj]

@missirol All your comments have been addressed in current version.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36828/28075

• This PR adds an extra 24KB to repository

• Found files with invalid states:

  • HLTrigger/HLTfilters/plugins/HLTDoubletSinglet.cc:
    • Added: 446b92f
    • Modified: 44279c7, aab8d43, f0309d0
    • Deleted: a544e37
  • HLTrigger/HLTfilters/plugins/HLTDoubleSinglet.cc:
    • Added: e11a3e8
    • Modified: 57c378a
    • Deleted: e913bf7
  • HLTrigger/HLTfilters/plugins/HLTDoubleSinglet.h:
    • Added: e11a3e8
    • Modified: 57c378a
    • Deleted: e913bf7

[cmsbuild]

Pull request #36828 was updated. @cmsbuild, @missirol, @Martin-Grunewald can you please check and sign again.

[missirol]

please test

All your comments have been addressed in current version.

Thanks @mbluj . No further comments from my side.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-907445/22124/summary.html
COMMIT: a544e37
CMSSW: CMSSW_12_3_X_2022-02-01-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36828/22124/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 43
• DQMHistoTests: Total histograms compared: 3449612
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3449590
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 42 files compared)
• Checked 181 log files, 42 edm output root files, 43 DQM output files
• TriggerResults: no differences found

[missirol]

+hlt

• addition of a new HLTFilter, not presently used in any wf or HLT menu

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1