Update Scouting Run3 format

[alintulu]

PR description:

• Several features of the PF Candidate bestTrack() has been added to the class Run3ScoutingParticle. The included variables are necessary to run b-tagging with ParticleNet, and has also been identified as helpful for additional analyses groups.
• A couple of changes to HLTScoutingPFProducer.cc to bring the overall scouting data size down. These include:
  • Reduced precision of vertex and jet quantities.
  • Configurable option (doCandIndsForJets) which dictates if the output should contain the indices of the PF constituents of the jet.
• Reduced precision of the vertex quantities in the primary vertex producer.
• Pt cut (default value of 0.3) for tracks in the track producer.

PR validation:

I ran scram b runtests as well as runTheMatrix. On lxplus runTheMatrix came back with 9 fails but all due to DAS_ERROR.

[alintulu]

@clelange @dsperka

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36840/28030

• This PR adds an extra 24KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File DataFormats/Scouting/src/classes.h modified in PR(s): Using new Run3ScoutingHitPattern class for hitPattern in Run-3 scouting #35685
  • File DataFormats/Scouting/src/classes_def.xml modified in PR(s): Using new Run3ScoutingHitPattern class for hitPattern in Run-3 scouting #35685

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36840/28030/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36840/28030/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36840/28031

• This PR adds an extra 24KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File DataFormats/Scouting/src/classes.h modified in PR(s): Using new Run3ScoutingHitPattern class for hitPattern in Run-3 scouting #35685
  • File DataFormats/Scouting/src/classes_def.xml modified in PR(s): Using new Run3ScoutingHitPattern class for hitPattern in Run-3 scouting #35685

[cmsbuild]

A new Pull Request was created by @alintulu (Adelina Lintuluoto) for master.

It involves the following packages:

• DataFormats/Scouting (core)
• HLTrigger/JetMET (hlt)
• HLTrigger/Muon (hlt)

@Martin-Grunewald, @Dr15Jones, @smuzaffar, @makortel, @cmsbuild, @missirol can you please review it and eventually sign? Thanks.
@Fedespring, @HuguesBrun, @missirol, @silviodonato, @abbiendi, @rovere, @Martin-Grunewald, @calderona, @sscruz, @jhgoh, @CeliaFernandez, @trocino, @cericeci this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[Martin-Grunewald]

Hmm, typically we do not add new V2 versions of C++ files but rather modify/evolve the existing code and files. What is the reason here?

[missirol]

Here's a first round of comments.

[alintulu]

Hmm, typically we do not add new V2 versions of C++ files but rather modify/evolve the existing code and files. What is the reason here?

It was decided with @dsperka that keeping the old version would allow us to more easily change producers if necessary. David, maybe you would like to elaborate on this?

[Martin-Grunewald]

Hmm, I would not want to have variants of code around, based on studies you should settle on one and refine/update that one again if needed (both producer and dataformat), esp. if one is a (almost?) superset of the other.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36840/28038

ERROR: Build errors found during clang-tidy run.

--
HLTrigger/JetMET/plugins/HLTScoutingPFProducerV2.cc:114:97: error: use of undeclared identifier 'mantissaPrecision'; did you mean 'mantissaPrecision_'? [clang-diagnostic-error]
                                MiniFloatConverter::reduceMantissaToNbitsRounding(vtx.yError(), mantissaPrecision),
                                                                                                ^~~~~~~~~~~~~~~~~
                                                                                                mantissaPrecision_
--
HLTrigger/JetMET/plugins/HLTScoutingPFProducerV2.cc:116:95: error: use of undeclared identifier 'mantissaPrecision'; did you mean 'mantissaPrecision_'? [clang-diagnostic-error]
                                MiniFloatConverter::reduceMantissaToNbitsRounding(vtx.chi2(), mantissaPrecision),
                                                                                              ^~~~~~~~~~~~~~~~~
                                                                                              mantissaPrecision_
--
HLTrigger/JetMET/plugins/HLTScoutingPFProducerV2.cc:133:7: error: use of undeclared identifier 'doMet' [clang-diagnostic-error]
  if (doMet && iEvent.getByToken(metCollection_, metCollection)) {
      ^
HLTrigger/JetMET/plugins/HLTScoutingPFProducerV2.cc:141:7: error: use of undeclared identifier 'doCandidates' [clang-diagnostic-error]
  if (doCandidates && iEvent.getByToken(pfCandidateCollection_, pfCandidateCollection)) {
      ^
HLTrigger/JetMET/plugins/HLTScoutingPFProducerV2.cc:143:23: error: use of undeclared identifier 'pfCandidatePtCut'; did you mean 'pfCandidatePtCut_'? [clang-diagnostic-error]
      if (cand.pt() > pfCandidatePtCut && std::abs(cand.eta()) < pfCandidateEtaCut) {
                      ^~~~~~~~~~~~~~~~
                      pfCandidatePtCut_
--
gmake: *** [config/SCRAM/GMake/Makefile.coderules:129: code-checks] Error 2
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36840/28148

• This PR adds an extra 28KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File DataFormats/Scouting/src/classes_def.xml modified in PR(s): Using new Run3ScoutingHitPattern class for hitPattern in Run-3 scouting #35685

[missirol]

please test

[cmsbuild]

Pull request #36840 was updated. @makortel, @missirol, @Dr15Jones, @Martin-Grunewald, @smuzaffar can you please check and sign again.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3cb4b5/22223/summary.html
COMMIT: 752421e
CMSSW: CMSSW_12_3_X_2022-02-03-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36840/22223/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 9 differences found in the comparisons
• DQMHistoTests: Total files compared: 46
• DQMHistoTests: Total histograms compared: 3765022
• DQMHistoTests: Total failures: 19
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3764980
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 45 files compared)
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 193 log files, 42 edm output root files, 46 DQM output files
• TriggerResults: no differences found

[makortel]

+core

[missirol]

+hlt

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1