Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RepeatingCachedRootSource now supports Refs #36864

Merged
merged 1 commit into from Feb 3, 2022
Merged

RepeatingCachedRootSource now supports Refs #36864

merged 1 commit into from Feb 3, 2022

Conversation

Dr15Jones
Copy link
Contributor

PR description:

  • Added the necessary infrastructure to support Ref like classes when doing a delayed read from RepeatingCachedRootSource.
  • Extended the unit test to read and check Refs.

PR validation:

Code compiles and framework unit tests pass.

@cmsbuild cmsbuild added this to the CMSSW_12_3_X milestone Feb 2, 2022
@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 2, 2022

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36864/28119

  • This PR adds an extra 16KB to repository

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 2, 2022

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

  • IOPool/Input (core)

@makortel, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks.
@makortel, @wddgit this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

This was referenced Feb 2, 2022
Closed
Closed
makortel
makortel reviewed Feb 2, 2022
View reviewed changes
IOPool/Input/src/RepeatingCachedRootSource.cc
std::optional<std::tuple<WrapperBase const*, unsigned int>>
RepeatingCachedRootSource::RCProductGetter::getThinnedProduct(ProductID const&, unsigned int key) const {
return {};
};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do these imply that RepeatingCachedRootSource does not support thinned products?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct. As that feature isn't used in production and is most likely not being used in the 'wild' I didn't feel it was worth the effort to try to get to work.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tend to agree. How about adding a comment somewhere here that this feature is intentionally omitted for now, and can be added later if there is use for it? (to avoid the need to wonder in the future if the case was that or if there was some fundamental reason)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@Dr15Jones
RepeatingCachedRootSource now supports Refs
3c09a67 
Added the necessary infrastructure to support Ref like classes
when doing a delayed read from RepeatingCachedRootSource.
Extended the unit test to read and check Refs.
@Dr15Jones Dr15Jones force-pushed the workingRefInRepeatingCachedRootSource branch from b1a3423 to 3c09a67 Compare February 2, 2022 19:20
@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 2, 2022

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36864/28123

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 2, 2022

Pull request #36864 was updated. @cmsbuild, @smuzaffar, @Dr15Jones, @makortel can you please check and sign again.

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 2, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fdde03/22168/summary.html
COMMIT: 3c09a67
CMSSW: CMSSW_12_3_X_2022-02-02-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36864/22168/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-fdde03/39434.0_TTbar_14TeV+2026D88+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-fdde03/39496.0_CloseByPGun_CE_E_Front_120um+2026D88+CE_E_Front_120um_GenSimHLBeamSpotHGCALCloseBy+DigiTrigger+RecoGlobal+HARVESTGlobal
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-fdde03/39500.0_CloseByPGun_CE_H_Coarse_Scint+2026D88+CE_H_Coarse_Scint_GenSimHLBeamSpotHGCALCloseBy+DigiTrigger+RecoGlobal+HARVESTGlobal

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 46
  • DQMHistoTests: Total histograms compared: 3765022
  • DQMHistoTests: Total failures: 8
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3764992
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
  • Checked 193 log files, 42 edm output root files, 46 DQM output files
  • TriggerResults: no differences found

@makortel
Copy link
Contributor

makortel commented Feb 3, 2022

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 3, 2022

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Feb 3, 2022

+1

@cmsbuild cmsbuild merged commit 0da411f into cms-sw:master Feb 3, 2022
@cmsbuild cmsbuild mentioned this pull request Feb 3, 2022
Merged
@Dr15Jones Dr15Jones deleted the workingRefInRepeatingCachedRootSource branch February 10, 2022 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makortel makortel makortel left review comments

Assignees
No one assigned
Labels
code-checks-approved core-approved fully-signed orp-approved tests-approved
Projects
None yet
Milestone
CMSSW_12_3_X
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Dr15Jones @cmsbuild @makortel @qliphy