Add lumi and run SimpleFlatTableProducer interfaces

[simonepigazzini]

PR description:

• Add a general interface for NanoAOD's SimpleFlatTableProducer to dump collections in Lumi and Run trees.
• The interface is copied from the Event tree equivalent producers

PR validation:

• I tested a custom workflow (for ECAL calibration) using these producers.
• The produced tables are correctly dumped by both the NANOAOD and NANOAODEDM output modules.

The test workflow mentioned above will be part of a separate PR, we are investigating the possibility to run it as part of an ALCARECO.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36902/28189

• This PR adds an extra 16KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File PhysicsTools/NanoAOD/interface/SimpleFlatTableProducer.h modified in PR(s): BeamSpot + Rho variables in nanoAODs #36037

[cmsbuild]

A new Pull Request was created by @simonepigazzini for master.

It involves the following packages:

• PhysicsTools/NanoAOD (xpog)

@cmsbuild, @mariadalfonso, @gouskos, @fgolf can you please review it and eventually sign? Thanks.
@gpetruc, @swertz this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[mariadalfonso]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-895d78/22259/summary.html
COMMIT: 5e645db
CMSSW: CMSSW_12_3_X_2022-02-06-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36902/22259/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 1 differences found in the comparisons
• DQMHistoTests: Total files compared: 46
• DQMHistoTests: Total histograms compared: 3766018
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3765994
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
• Checked 193 log files, 42 edm output root files, 46 DQM output files
• TriggerResults: no differences found

[simonepigazzini]

I addressed part of the comments in #36461:

• Removed call to mayConsumes since the input collection is always requested.
• Moved the auxiliary Variable classes outside the Event/Lumi/Run base classes.
• Vector are now passed by reference to the fill method

I did not change the producer fromone to global since in the issue the benefits of this change are not clearly stated. I also did not remove the calls to existsAs since this would require reviewing all the modules based on these producers to make sure the parameters are always defined.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36902/28219

• This PR adds an extra 16KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File PhysicsTools/NanoAOD/interface/SimpleFlatTableProducer.h modified in PR(s): BeamSpot + Rho variables in nanoAODs #36037

[cmsbuild]

Pull request #36902 was updated. @cmsbuild, @mariadalfonso, @gouskos, @fgolf can you please check and sign again.

[mariadalfonso]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-895d78/22289/summary.html
COMMIT: 3e48ccc
CMSSW: CMSSW_12_3_X_2022-02-08-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36902/22289/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 46
• DQMHistoTests: Total histograms compared: 3765080
• DQMHistoTests: Total failures: 13
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3765044
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 45 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 193 log files, 42 edm output root files, 46 DQM output files
• TriggerResults: no differences found

[mariadalfonso]

+xpog

• changes in view of the ALCAnano with more Lumi/Run tables
• verified no changes up to analysis tree
• done part of the class cleanup requested in the previous issue

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1