Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hltGetConfiguration updates to deal with FinalPaths and new OutputModule #36969

Conversation

Martin-Grunewald
Copy link
Contributor

PR description:

hltGetConfiguration updates to deal with FinalPaths and new OutputModule
Based on CMSSW_12_2_1

PR validation:

TSG tests

if this PR is a backport please specify the original PR and why you need to backport that PR:

Backport of #36878
Required by new ConfDb

@Martin-Grunewald
Copy link
Contributor Author

type backport

@cmsbuild cmsbuild added this to the CMSSW_12_2_X milestone Feb 15, 2022
@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 15, 2022

A new Pull Request was created by @Martin-Grunewald (Martin Grunewald) for CMSSW_12_2_X.

It involves the following packages:

  • HLTrigger/Configuration (hlt)

@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@silviodonato, @missirol this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@Martin-Grunewald
Copy link
Contributor Author

backport of #36878

@Martin-Grunewald
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cfb4f5/22426/summary.html
COMMIT: e21a801
CMSSW: CMSSW_12_2_X_2022-02-15-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36969/22426/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 42
  • DQMHistoTests: Total histograms compared: 3251294
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3251272
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 41 files compared)
  • Checked 177 log files, 37 edm output root files, 42 DQM output files
  • TriggerResults: no differences found

@Martin-Grunewald
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Feb 16, 2022

+1

@cmsbuild cmsbuild merged commit b154711 into cms-sw:CMSSW_12_2_X Feb 16, 2022
@missirol missirol deleted the hltGetConfigurationFinalPathFixes_1221 branch February 16, 2022 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants