Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update of HLT-E/Gamma modules to avoid accessing L1CaloGeometry unnecessarily #36986

Merged
merged 1 commit into from Feb 17, 2022

Conversation

missirol
Copy link
Contributor

@missirol missirol commented Feb 16, 2022

resolves #36806

PR description:

This PR updates a couple of HLT-E/Gamma modules in order not to access the L1CaloGeometry ES product unnecessarily.

The modules in question come from class templates, and in the original implementation the L1CaloGeometry object was created regardless of configuration/template parameters. On the other hand, the L1CaloGeometry object is not really needed for configuration/template parameters in use in the Run-3 HLT menu (basically, the L1CaloGeometry object is needed when the HLT modules need to use the l1extra objects from the Stage-1 L1T, and that is never the case in HLT menus for Run 3).

This update should facilitate the removal of the relevant record from the Run-3 HLT GT (see #36806 and related issues/PRs).

[ The change in autoCond is temporary, and will be removed before integration (I tested wf 139.004 locally w/o the tag L1CaloGeometry_CRAFT09_hlt, but this should be tested centrally, and I don't know a better way to do that). ]

Merely technical. No changes expected.

PR validation:

runTheMatrix -l 139.004, addOnTests.py, and verified that all trigger-objects are unchanged for 100 MC events processed with the HLT GRun menu.

If this PR is a backport, please specify the original PR and why you need to backport that PR:

N/A

@missirol
Copy link
Contributor Author

missirol commented Feb 16, 2022

test parameters:

  • workflows = 139.004

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36986/28364

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @missirol (Marino Missiroli) for master.

It involves the following packages:

  • Configuration/AlCa (alca)
  • RecoEgamma/EgammaHLTProducers (hlt)

@malbouis, @yuanchao, @cmsbuild, @missirol, @Martin-Grunewald, @francescobrivio, @tvami can you please review it and eventually sign? Thanks.
@sscruz, @Sam-Harper, @HuguesBrun, @silviodonato, @jainshilpi, @valsdav, @tocheng, @lgray, @Martin-Grunewald, @calderona, @sobhatta, @Fedespring, @fabiocos, @afiqaize, @wrtabb, @mmusich, @varuns23, @cericeci, @ram1123 this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@tvami
Copy link
Contributor

tvami commented Feb 16, 2022

@cmsbuild , please test

@tvami
Copy link
Contributor

tvami commented Feb 16, 2022

@missirol can you please update the description by including "resolves #36806"

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-730d6d/22467/summary.html
COMMIT: 212ac8f
CMSSW: CMSSW_12_3_X_2022-02-16-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36986/22467/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-730d6d/138.4_PromptCollisions+RunMinimumBias2021+ALCARECOPROMPTR3+HARVESTDPROMPTR3
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-730d6d/138.5_ExpressCollisions+RunMinimumBias2021+TIER0EXPRUN3+ALCARECOEXPR3+HARVESTDEXPR3
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-730d6d/139.001_RunMinimumBias2021+RunMinimumBias2021+HLTDR3_2021+RECODR3_MinBiasOffline+HARVESTD2021MB
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-730d6d/139.004_RunNoBPTX2021+RunNoBPTX2021+HLTDR3_2021+RECODR3_AlCaTkCosmics_Offline+HARVESTDR3

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3965143
  • DQMHistoTests: Total failures: 8
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3965113
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 204 log files, 45 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36986/28373

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

Pull request #36986 was updated. @cmsbuild, @missirol, @Martin-Grunewald can you please check and sign again.

@missirol
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-730d6d/22473/summary.html
COMMIT: c2a3474
CMSSW: CMSSW_12_3_X_2022-02-16-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36986/22473/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-730d6d/138.4_PromptCollisions+RunMinimumBias2021+ALCARECOPROMPTR3+HARVESTDPROMPTR3
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-730d6d/138.5_ExpressCollisions+RunMinimumBias2021+TIER0EXPRUN3+ALCARECOEXPR3+HARVESTDEXPR3
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-730d6d/139.001_RunMinimumBias2021+RunMinimumBias2021+HLTDR3_2021+RECODR3_MinBiasOffline+HARVESTD2021MB
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-730d6d/139.004_RunNoBPTX2021+RunNoBPTX2021+HLTDR3_2021+RECODR3_AlCaTkCosmics_Offline+HARVESTDR3

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3965143
  • DQMHistoTests: Total failures: 14
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3965107
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 204 log files, 45 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@missirol
Copy link
Contributor Author

In the first round of tests, the Run-3 HLT GT 123X_dataRun3_HLT_v2 (which does not include any L1CaloGeometryRecord) was used, and wf 139.004 passed, confirming that this PR addresses #36940 (comment).

The second round of tests confirmed that this PR does not introduce differences in outputs with respect to master, and all tested workflows (the default ones + 139.004) passed.

If this PR is merged, it will automatically close issue #36806.

@francescobrivio
Copy link
Contributor

+alca (for what it's worth)

@missirol
Copy link
Contributor Author

do you think we might need this fix for CRAFT and hence a backport to 12_2_X and and new 12_2 release?

Afaiu.. the only problematic situation in 12_2_X is an HLT menu where (1) one of the modules in this PR is used , and (2) the HLT GT 122X_dataRun3_HLT_v3 is used.

I don't think (1) applies to any of the HLT menus for CRAFT, but we would have to confirm with TSG/FOG. The safest would be to use 122X_dataRun3_HLT_v4 in CRAFT (just like it is being used offline for 12_2_X) to negate (2). This way one would not need a backport of this PR and a corresponding new release.

@missirol
Copy link
Contributor Author

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Obsolete tags PCaloGeometry_Castor_v1_hlt and L1CaloGeometry_CRAFT09_hlt still consumed by code
5 participants