New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update of HLT-E/Gamma modules to avoid accessing L1CaloGeometry
unnecessarily
#36986
Conversation
test parameters:
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36986/28364
|
A new Pull Request was created by @missirol (Marino Missiroli) for master. It involves the following packages:
@malbouis, @yuanchao, @cmsbuild, @missirol, @Martin-Grunewald, @francescobrivio, @tvami can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild , please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-730d6d/22467/summary.html Comparison Summary@slava77 comparisons for the following workflows were not done due to missing matrix map:
Summary:
|
212ac8f
to
c2a3474
Compare
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36986/28373
|
Pull request #36986 was updated. @cmsbuild, @missirol, @Martin-Grunewald can you please check and sign again. |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-730d6d/22473/summary.html Comparison Summary@slava77 comparisons for the following workflows were not done due to missing matrix map:
Summary:
|
In the first round of tests, the Run-3 HLT GT The second round of tests confirmed that this PR does not introduce differences in outputs with respect to If this PR is merged, it will automatically close issue #36806. |
+alca (for what it's worth)
|
Afaiu.. the only problematic situation in I don't think (1) applies to any of the HLT menus for CRAFT, but we would have to confirm with TSG/FOG. The safest would be to use |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
resolves #36806
PR description:
This PR updates a couple of HLT-E/Gamma modules in order not to access the
L1CaloGeometry
ES product unnecessarily.The modules in question come from class templates, and in the original implementation the
L1CaloGeometry
object was created regardless of configuration/template parameters. On the other hand, theL1CaloGeometry
object is not really needed for configuration/template parameters in use in the Run-3 HLT menu (basically, theL1CaloGeometry
object is needed when the HLT modules need to use thel1extra
objects from the Stage-1 L1T, and that is never the case in HLT menus for Run 3).This update should facilitate the removal of the relevant record from the Run-3 HLT GT (see #36806 and related issues/PRs).
[ The change in
autoCond
is temporary, and will be removed before integration (I tested wf139.004
locally w/o the tagL1CaloGeometry_CRAFT09_hlt
, but this should be tested centrally, and I don't know a better way to do that). ]Merely technical. No changes expected.
PR validation:
runTheMatrix -l 139.004
,addOnTests.py
, and verified that all trigger-objects are unchanged for 100 MC events processed with the HLT GRun menu.If this PR is a backport, please specify the original PR and why you need to backport that PR:
N/A