Run3-alca218D Clean some of the remaining Hcal calibration codes in Calibration/HcalCalibAlgos #36987

bsunanda · 2022-02-16T19:36:50Z

PR description:

Clean some of the remaining Hcal calibration codes in Calibration/HcalCalibAlgos

PR validation:

Use some of the test workflows in Calibration/HcalCalibAlgos/test/python

if this PR is a backport please specify the original PR and why you need to backport that PR:

Nothing special

…lCalibAlgos

cmsbuild · 2022-02-16T19:45:05Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36987/28369

This PR adds an extra 40KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36987/28369/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36987/28369/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2022-02-16T19:56:03Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36987/28370

This PR adds an extra 40KB to repository

cmsbuild · 2022-02-16T19:56:27Z

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

Calibration/HcalCalibAlgos (alca)

@cmsbuild, @malbouis, @tvami, @yuanchao, @francescobrivio can you please review it and eventually sign? Thanks.
@mmusich, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

tvami · 2022-02-16T20:01:31Z

Calibration/HcalCalibAlgos/plugins/RecAnalyzerMinbias.cc

@@ -504,8 +499,7 @@ void RecAnalyzerMinbias::analyze(const edm::Event& iEvent, const edm::EventSetup
    h_AmplitudeHF_->Fill(amplitudefullHF);
  }

-  edm::Handle<HBHERecHitCollection> hbheMB;
-  iEvent.getByToken(tok_hbherecoMB_, hbheMB);
+  const edm::Handle<HBHERecHitCollection>& hbheMB = iEvent.getHandle(tok_hbherecoMB_);
  if (!hbheMB.isValid()) {
    edm::LogWarning("RecAnalyzer") << "HcalCalibAlgos: Error! can't get hbhe product!";


Suggested change

edm::LogWarning("RecAnalyzer") << "HcalCalibAlgos: Error! can't get hbhe product!";

edm::LogWarning("RecAnalyzerMinbias") << "HcalCalibAlgos: Error! can't get hbhe product!";

This is the correct module name

tvami · 2022-02-16T20:02:57Z

Calibration/HcalCalibAlgos/plugins/SimAnalyzerMinbias.cc

@@ -147,8 +143,7 @@ void SimAnalyzerMinbias::analyze(const edm::Event& iEvent, const edm::EventSetup
                                   << myGenEvent->vertices_size() << " vertices";
  }

-  edm::Handle<edm::PCaloHitContainer> hcalHits;
-  iEvent.getByToken(tok_hcal_, hcalHits);
+  const edm::Handle<edm::PCaloHitContainer>& hcalHits = iEvent.getHandle(tok_hcal_);
  if (!hcalHits.isValid()) {
    edm::LogWarning("AnalyzerMB") << "Error! can't get HcalHits product!";


Suggested change

edm::LogWarning("AnalyzerMB") << "Error! can't get HcalHits product!";

edm::LogWarning("SimAnalyzerMinbias") << "Error! can't get HcalHits product!";

tvami · 2022-02-16T20:04:21Z

@cmsbuild , please test

cmsbuild · 2022-02-16T21:29:42Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36987/28371

This PR adds an extra 40KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36987/28371/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36987/28371/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2022-02-17T03:03:06Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f83261/22472/summary.html
COMMIT: 5583aa8
CMSSW: CMSSW_12_3_X_2022-02-16-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36987/22472/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-f83261/138.4_PromptCollisions+RunMinimumBias2021+ALCARECOPROMPTR3+HARVESTDPROMPTR3
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-f83261/138.5_ExpressCollisions+RunMinimumBias2021+TIER0EXPRUN3+ALCARECOEXPR3+HARVESTDEXPR3
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-f83261/139.001_RunMinimumBias2021+RunMinimumBias2021+HLTDR3_2021+RECODR3_MinBiasOffline+HARVESTD2021MB

Summary:

No significant changes to the logs found
Reco comparison results: 2 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3965143
DQMHistoTests: Total failures: 8
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3965113
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
Checked 204 log files, 45 edm output root files, 49 DQM output files
TriggerResults: no differences found

tvami · 2022-02-17T14:46:32Z

Hi @bsunanda in Calibration/HcalCalibAlgos/plugins/HOCalibAnalyzer.cc there is a dead assignment of tmpsect, please remove it.

bsunanda · 2022-02-17T15:11:23Z

@cmsbuild Please test

cmsbuild · 2022-02-17T15:15:54Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36987/28383

This PR adds an extra 16KB to repository

cmsbuild · 2022-02-17T15:16:13Z

Pull request #36987 was updated. @malbouis, @tvami, @yuanchao, @francescobrivio can you please check and sign again.

cmsbuild · 2022-02-17T19:19:49Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f83261/22485/summary.html
COMMIT: 6d4a1b8
CMSSW: CMSSW_12_3_X_2022-02-17-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36987/22485/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-f83261/138.4_PromptCollisions+RunMinimumBias2021+ALCARECOPROMPTR3+HARVESTDPROMPTR3
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-f83261/138.5_ExpressCollisions+RunMinimumBias2021+TIER0EXPRUN3+ALCARECOEXPR3+HARVESTDEXPR3
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-f83261/139.001_RunMinimumBias2021+RunMinimumBias2021+HLTDR3_2021+RECODR3_MinBiasOffline+HARVESTD2021MB

Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3965143
DQMHistoTests: Total failures: 7
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 3965113
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -0.004 KiB( 48 files compared)
DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
Checked 204 log files, 45 edm output root files, 49 DQM output files
TriggerResults: no differences found

tvami · 2022-02-17T19:25:59Z

+alca

cmsbuild · 2022-02-17T19:26:23Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

perrotta · 2022-02-17T20:34:43Z

+1

Clean some of the remaining Hcal calibration codes in Calibration/Hca…

6d75b13

…lCalibAlgos

cmsbuild added this to the CMSSW_12_3_X milestone Feb 16, 2022

cmsbuild added alca-pending code-checks-pending orp-pending pending-signatures tests-pending labels Feb 16, 2022

cmsbuild added code-checks-rejected and removed code-checks-pending labels Feb 16, 2022

Code check

46e770f

cmsbuild added code-checks-pending and removed code-checks-rejected labels Feb 16, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Feb 16, 2022

tvami reviewed Feb 16, 2022

View reviewed changes

cmsbuild added tests-started and removed tests-pending labels Feb 16, 2022

Take Tamas's comments

8c4ee44

cmsbuild added code-checks-pending tests-pending and removed tests-started code-checks-approved labels Feb 16, 2022

cmsbuild added code-checks-rejected and removed code-checks-pending labels Feb 16, 2022

cmsbuild added tests-approved and removed tests-started labels Feb 17, 2022

Remove the dead assignment in HOCalibAnalyzer

6d4a1b8

cmsbuild added code-checks-pending tests-pending and removed tests-approved code-checks-approved labels Feb 17, 2022

cmsbuild added tests-started and removed tests-pending labels Feb 17, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Feb 17, 2022

cmsbuild added tests-approved and removed tests-started labels Feb 17, 2022

cmsbuild added alca-approved fully-signed and removed alca-pending pending-signatures labels Feb 17, 2022

cmsbuild added orp-approved and removed orp-pending labels Feb 17, 2022

cmsbuild merged commit 0aad040 into cms-sw:master Feb 17, 2022

cmsbuild mentioned this pull request Feb 18, 2022

Implementation of beam halo tagger algorithm for the endcap photons #36901

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Run3-alca218D Clean some of the remaining Hcal calibration codes in Calibration/HcalCalibAlgos #36987

Run3-alca218D Clean some of the remaining Hcal calibration codes in Calibration/HcalCalibAlgos #36987

bsunanda commented Feb 16, 2022

cmsbuild commented Feb 16, 2022

cmsbuild commented Feb 16, 2022

cmsbuild commented Feb 16, 2022

tvami Feb 16, 2022

tvami Feb 16, 2022

tvami commented Feb 16, 2022

cmsbuild commented Feb 16, 2022

cmsbuild commented Feb 17, 2022

tvami commented Feb 17, 2022

bsunanda commented Feb 17, 2022

cmsbuild commented Feb 17, 2022

cmsbuild commented Feb 17, 2022

cmsbuild commented Feb 17, 2022

tvami commented Feb 17, 2022

cmsbuild commented Feb 17, 2022

perrotta commented Feb 17, 2022

	edm::LogWarning("RecAnalyzer") << "HcalCalibAlgos: Error! can't get hbhe product!";
	edm::LogWarning("RecAnalyzerMinbias") << "HcalCalibAlgos: Error! can't get hbhe product!";

	edm::LogWarning("AnalyzerMB") << "Error! can't get HcalHits product!";
	edm::LogWarning("SimAnalyzerMinbias") << "Error! can't get HcalHits product!";

Run3-alca218D Clean some of the remaining Hcal calibration codes in Calibration/HcalCalibAlgos #36987

Run3-alca218D Clean some of the remaining Hcal calibration codes in Calibration/HcalCalibAlgos #36987

Conversation

bsunanda commented Feb 16, 2022

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented Feb 16, 2022

cmsbuild commented Feb 16, 2022

cmsbuild commented Feb 16, 2022

tvami Feb 16, 2022

Choose a reason for hiding this comment

tvami Feb 16, 2022

Choose a reason for hiding this comment

tvami commented Feb 16, 2022

cmsbuild commented Feb 16, 2022

cmsbuild commented Feb 17, 2022

Comparison Summary

tvami commented Feb 17, 2022

bsunanda commented Feb 17, 2022

cmsbuild commented Feb 17, 2022

cmsbuild commented Feb 17, 2022

cmsbuild commented Feb 17, 2022

Comparison Summary

tvami commented Feb 17, 2022

cmsbuild commented Feb 17, 2022

perrotta commented Feb 17, 2022