New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed all the overlaps inside the Muon Yoke (2021/v6/muonYoke.xml) #36997
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36997/28392
|
A new Pull Request was created by @slomeo (Sergio Lo Meo) for master. It involves the following packages:
@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-69a38d/22497/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
@civanch @cvuosalo @rappoccio (just to be sure that this is taken into account) |
@perrotta , this is a new version of the file with fixes of tiny overlaps. It is not included into any scenario yet. We are collecting similar fixes to be ready for 2024 variant of Run-3 geometry when extra RPC chambers will be added. We do not yet decided when we will make a new alternative Run-3 scenario and when will make a WF to test it. |
Thank you @civanch |
@perrotta , we cannot exclude that we will create 2021 alternative scenario. It is why initially we put this xml into 2021 sub-derectory. I would not exclude in future if it will be moved to 2024, which not yet exist, or will stay in this place forever. |
+1
|
PR description:
Fixed all the overlaps in the Muon Yoke listed by @etcherniaev 's talk (slide 6) in https://indico.cern.ch/event/1117488/ .
A new version of muonYoke.xml is created (i.e 2021/v6/muonYoke.xml)
@bsunanda @ianna @cvuosalo @civanch @etcherniaev : FYI
PR validation:
validation by "nohup cmsRun SimG4Core/PrintGeomInfo/test/python/g4OverlapCheck_dd4hep_cfg.py >& overlaps.out &"
I set tolerance equal to 0.00001 to find nm overlaps.
Muon's volumes are not present in the overlaps.out file.
if this PR is a backport please specify the original PR and why you need to backport that PR:
nothing special