Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed all the overlaps inside the Muon Yoke (2021/v6/muonYoke.xml) #36997

Merged
merged 1 commit into from Feb 23, 2022

Conversation

slomeo
Copy link
Contributor

@slomeo slomeo commented Feb 18, 2022

PR description:

Fixed all the overlaps in the Muon Yoke listed by @etcherniaev 's talk (slide 6) in https://indico.cern.ch/event/1117488/ .
A new version of muonYoke.xml is created (i.e 2021/v6/muonYoke.xml)

@bsunanda @ianna @cvuosalo @civanch @etcherniaev : FYI

PR validation:

validation by "nohup cmsRun SimG4Core/PrintGeomInfo/test/python/g4OverlapCheck_dd4hep_cfg.py >& overlaps.out &"
I set tolerance equal to 0.00001 to find nm overlaps.

Muon's volumes are not present in the overlaps.out file.

if this PR is a backport please specify the original PR and why you need to backport that PR:

nothing special

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36997/28392

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @slomeo (Sergio Lo Meo) for master.

It involves the following packages:

  • Geometry/MuonCommonData (geometry)

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks.
@ptcox, @bsunanda, @fabiocos this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@civanch
Copy link
Contributor

civanch commented Feb 18, 2022

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-69a38d/22497/summary.html
COMMIT: ad9a60a
CMSSW: CMSSW_12_3_X_2022-02-17-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36997/22497/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3965143
  • DQMHistoTests: Total failures: 13
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3965107
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 204 log files, 45 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@cvuosalo
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

@civanch @cvuosalo @rappoccio (just to be sure that this is taken into account)
This PR changes, indeed in a very limited way, the Run3 geometry. Tiny effects on the simulated and reconstructed quantities are therefore unavoidable and expected (even if not visible in the outputs of the bot tests here). Is it intended and accepted by everybody that this change will enter the 2021 Run3 geometry in 12_3_X, which will therefore be slightly different from the one recently implemented in 12_2_X?

@civanch
Copy link
Contributor

civanch commented Feb 23, 2022

@perrotta , this is a new version of the file with fixes of tiny overlaps. It is not included into any scenario yet. We are collecting similar fixes to be ready for 2024 variant of Run-3 geometry when extra RPC chambers will be added. We do not yet decided when we will make a new alternative Run-3 scenario and when will make a WF to test it.

@perrotta
Copy link
Contributor

@perrotta , this is a new version of the file with fixes of tiny overlaps. It is not included into any scenario yet. We are collecting similar fixes to be ready for 2024 variant of Run-3 geometry when extra RPC chambers will be added. We do not yet decided when we will make a new alternative Run-3 scenario and when will make a WF to test it.

Thank you @civanch
Ok, this indeed corresponds to the plan we were aware of.
I got confused for it being stored in a "2021" data repository, instead of a "2024" (or "2023") one: can you please confirm that this is also intended?

@civanch
Copy link
Contributor

civanch commented Feb 23, 2022

@perrotta , we cannot exclude that we will create 2021 alternative scenario. It is why initially we put this xml into 2021 sub-derectory. I would not exclude in future if it will be moved to 2024, which not yet exist, or will stay in this place forever.

@perrotta
Copy link
Contributor

+1

  • Run3 geometry fixes with overlap removal in the Muon Yoke are made available but not included into any scenario yet

@cmsbuild cmsbuild merged commit 6743b63 into cms-sw:master Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants