Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change DQM modules to use stage-2 L1T #37033

Merged
merged 4 commits into from Feb 24, 2022
Merged

Conversation

tvami
Copy link
Contributor

@tvami tvami commented Feb 22, 2022

PR description:

Based on #37016 (comment)
this PR moves different DQM modules to use stage-2 L1T

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A

Resolves #37016

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37033/28462

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @tvami (Tamas Vami) for master.

It involves the following packages:

  • DQM/SiStripMonitorClient (dqm)
  • DQMOffline/Trigger (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please review it and eventually sign? Thanks.
@fioriNTU, @arossi83, @trocino, @HuguesBrun, @hdelanno, @missirol, @sroychow, @jhgoh, @calderona, @sscruz, @Fedespring, @threus, @jandrea, @idebruyn, @mmusich, @venturia, @mtosi, @cericeci, @rociovilar this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@tvami
Copy link
Contributor Author

tvami commented Feb 22, 2022

@cmsbuild , please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests RelVals RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9a15df/22584/summary.html
COMMIT: 20080e0
CMSSW: CMSSW_12_3_X_2022-02-22-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37033/22584/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test TestDQMOfflineConfiguration_10 had ERRORS
---> test TestDQMOfflineConfiguration_210 had ERRORS
---> test TestDQMOfflineConfiguration_220 had ERRORS
---> test TestDQMOfflineConfiguration_20 had ERRORS
and more ...

RelVals

----- Begin Fatal Exception 22-Feb-2022 18:16:54 CET-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Validating configuration of module: class=METMonitor label='PFMET110_PFMHT110_IDTight_METmonitoring'
Exception Message:
Illegal parameter found in configuration.  The parameter is named:
 'stage2'
You could be trying to use a parameter name that is not
allowed for this plugin or it could be misspelled.
----- End Fatal Exception -------------------------------------------------
----- Begin Fatal Exception 22-Feb-2022 18:18:40 CET-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Validating configuration of module: class=METMonitor label='PFMET110_PFMHT110_IDTight_METmonitoring'
Exception Message:
Illegal parameter found in configuration.  The parameter is named:
 'stage2'
You could be trying to use a parameter name that is not
allowed for this plugin or it could be misspelled.
----- End Fatal Exception -------------------------------------------------
----- Begin Fatal Exception 22-Feb-2022 18:23:49 CET-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Validating configuration of module: class=METMonitor label='PFMET110_PFMHT110_IDTight_METmonitoring'
Exception Message:
Illegal parameter found in configuration.  The parameter is named:
 'stage2'
You could be trying to use a parameter name that is not
allowed for this plugin or it could be misspelled.
----- End Fatal Exception -------------------------------------------------
Expand to see more relval errors ...

RelVals-INPUT

  • 136.7801136.7801_RunHLTPhy2017B_AOD+RunHLTPhy2017B_AOD+DQMHLTonAOD_2017+HARVESTDQMHLTonAOD_2017/step2_RunHLTPhy2017B_AOD+RunHLTPhy2017B_AOD+DQMHLTonAOD_2017+HARVESTDQMHLTonAOD_2017.log
  • 136.7803136.7803_RunHLTPhy2017B_RAWAOD+RunHLTPhy2017B_RAWAOD+DQMHLTonRAWAOD_2017+HARVESTDQMHLTonAOD_2017/step2_RunHLTPhy2017B_RAWAOD+RunHLTPhy2017B_RAWAOD+DQMHLTonRAWAOD_2017+HARVESTDQMHLTonAOD_2017.log
  • 138.5138.5_ExpressCollisions+RunMinimumBias2021+TIER0EXPRUN3+ALCARECOEXPR3+HARVESTDEXPR3/step2_ExpressCollisions+RunMinimumBias2021+TIER0EXPRUN3+ALCARECOEXPR3+HARVESTDEXPR3.log
Expand to see more relval errors ...

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37033/28465

@cmsbuild
Copy link
Contributor

Pull request #37033 was updated. @emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please check and sign again.

@tvami
Copy link
Contributor Author

tvami commented Feb 22, 2022

@cmsbuild , please test

@mmusich
Copy link
Contributor

mmusich commented Feb 23, 2022

@tvami I think the problem is that once you create the dict for changing the stage2 parameter in the configuration, it expects all the other ones to be defined as well.
e.g.:

cmsrel CMSSW_12_3_X_2022-02-22-2300/src/
cd CMSSW_12_3_X_2022-02-22-2300
cmsenv
git-fetch-user tvami
git checkout l1Stage1DQMmodule
git cms-addpkg DQM/SiStripMonitorClient DQMOffline/Trigger
scramv1 b -j 20
voms-proxy-init -voms cms
runTheMatrix.py -l 138.4
more138.4_PromptCollisions+RunMinimumBias2021+ALCARECOPROMPTR3+HARVESTDPROMPTR3/step2_PromptCollisions+RunMinimumBias2021+ALCARECOPROMPTR3+HARVESTDPROMPTR3.log

gives:

----- Begin Fatal Exception 23-Feb-2022 09:00:15 CET-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=MuonMonitor label='TrkMu12_DoubleTrkMu5NoFiltersNoVtx_monitoring'
Exception Message:
MissingParameter: Parameter 'l1tAlgBlkInputTag' not found.
----- End Fatal Exception -------------------------------------------------

if you add the parameter in the configuration, likely also the fillDescriptions needs to be updated....

@mmusich
Copy link
Contributor

mmusich commented Feb 23, 2022

tvami#5 this seems to make it go through.

add rest of parameters for GenericTriggerEventFlag in configuration / fillDescriptions
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37033/28485

@cmsbuild
Copy link
Contributor

Pull request #37033 was updated. @emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please check and sign again.

@tvami
Copy link
Contributor Author

tvami commented Feb 23, 2022

@cmsbuild , please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9a15df/22620/summary.html
COMMIT: df23d7c
CMSSW: CMSSW_12_3_X_2022-02-23-0800/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37033/22620/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 4001143
  • DQMHistoTests: Total failures: 8
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4001113
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 204 log files, 45 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor Author

tvami commented Feb 23, 2022

Yay, diffs show no changes, that's great I guess that means these tags were not really used anywhere indeed, otherwise I'd have expected at least some changes in the plots.

@jfernan2
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@tvami
Copy link
Contributor Author

tvami commented Feb 24, 2022

@cms-sw/orp-l2 can we please merge this in the 2300 IB? Just so I can remove the tag from the GT in that IB

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 5910b0e into cms-sw:master Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Old L1T tags consumed in DQM modules
5 participants