Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create cfi files for JetConstituentSelector<> plugins #37039

Merged
merged 1 commit into from Feb 25, 2022

Conversation

missirol
Copy link
Contributor

PR description:

This PR is technical. It enables the creation of default cfi files for all instances of the plugin template JetConstituentSelector.

This is expected to have no consequences for any existing workflow.

The reason to enable the creation of the said cfi files is that an external tool used by HLT (i.e. ConfDB) relies on the existence of cfi files to know the default configuration of CMSSW plugins.

Thanks to @rgerosa for reporting the issue.

Merely technical. No changes expected.

PR validation:

The new cfi files are created as expected.

If this PR is a backport, please specify the original PR and why you need to backport that PR:

N/A

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37039/28472

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @missirol (Marino Missiroli) for master.

It involves the following packages:

  • CommonTools/RecoAlgos (reconstruction)

@jpata, @cmsbuild, @clacaputo, @slava77 can you please review it and eventually sign? Thanks.
@rappoccio, @ahinzmann, @abbiendi, @jhgoh, @jdolen, @gkasieczka, @hatakeyamak this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@missirol
Copy link
Contributor Author

please test

@missirol
Copy link
Contributor Author

missirol commented Feb 23, 2022

please abort

The 1 error in the addOnTests comes from a crash related to MkFit. I'd say that's clearly unrelated to this PR.

The tests seem stuck anyways, so I will restart them with the fix in #37038.

@missirol
Copy link
Contributor Author

please test with #37038

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-543250/22622/summary.html
COMMIT: 3efc432
CMSSW: CMSSW_12_3_X_2022-02-23-0800/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37039/22622/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 4001143
  • DQMHistoTests: Total failures: 8
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4001113
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 204 log files, 45 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@missirol
Copy link
Contributor Author

assign hlt

for bookkeeping purposes

@cmsbuild
Copy link
Contributor

New categories assigned: hlt

@missirol,@Martin-Grunewald you have been requested to review this Pull request/Issue and eventually sign? Thanks

@missirol
Copy link
Contributor Author

missirol commented Feb 24, 2022

+hlt

  • this PR does not require any externals (the label requires-external comes from having to test with another PR due to an unrelated issue)

@jpata
Copy link
Contributor

jpata commented Feb 25, 2022

+reconstruction

  • technical fillDescriptions

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Feb 25, 2022

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants