introduce SiStripApvGainFromFileBuilder (reprise)

[mmusich]

PR description:

This is a re-cast of PR #8621 that never landed in cmssw, after having applied all the necessary modifications to comply with recent migrations.
The introduced plugin reads an ASCII input file containing the SiStrip APV gain from tick mark (G1 gain) and creates the payload in the sqlite file database. In normal operations this is carried out via O2O, but the functionality is kept here as a back-up.
The input file (CondTools/SiStrip/data/tickheight.txt) has been proposed to the CondTools-SiStrip data repo in the companion PR cms-data/CondTools-SiStrip#1.

PR validation:

The unit test introduced here runs successfully.

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37066/28516

• This PR adds an extra 376KB to repository

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

• CondTools/SiStrip (db)

@cmsbuild, @ggovi, @tvami, @malbouis, @francescobrivio can you please review it and eventually sign? Thanks.
@mmusich, @VinInn this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[tvami]

If a CondTools-SiStrip cms-data repo is created I will move the file there and remove it from git history (by the way there's a bunch of other files scattered in cmssw that would fit well there).

@smuzaffar can you please create that?

[tvami]

If a CondTools-SiStrip cms-data repo is created I will move the file there and remove it from git history (by the way there's a bunch of other files scattered in cmssw that would fit well there).

@smuzaffar can you please create that?

Or @cms-sw/orp-l2 ? I'm not sure who has the rights to do this. Thanks!

[qliphy]

@tvami @mmusich Please check here: https://github.com/cms-data/CondTools-SiStrip

[tvami]

Thanks @qliphy !

[mmusich]

test parameters:

• pull_request = Move tickheight file from cmssw cms-data/CondTools-SiStrip#1

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37066/28564

• This PR adds an extra 12KB to repository

[cmsbuild]

Pull request #37066 was updated. @cmsbuild, @ggovi, @tvami, @malbouis, @francescobrivio can you please check and sign again.

[mmusich]

@cmsbuild, please test

[cmsbuild]

-1

Failed Tests: ClangBuild
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0e0442/22705/summary.html
COMMIT: 61ea418
CMSSW: CMSSW_12_3_X_2022-02-27-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37066/22705/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @bsunanda Phase2-TB67 Clean up the analyzers of HGCal TB applications in SimG4CMS/HGCalTestBeam/plugins #37001

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0e0442/22705/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0e0442/22705/git-merge-result

Clang Build

I found compilation warning while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 64 COMPILER='llvm compile'

See details on the summary page.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37066/28593

• This PR adds an extra 20KB to repository

[cmsbuild]

Pull request #37066 was updated. @cmsbuild, @ggovi, @tvami, @malbouis, @francescobrivio can you please check and sign again.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37066/28594

• This PR adds an extra 24KB to repository

[cmsbuild]

Pull request #37066 was updated. @cmsbuild, @ggovi, @tvami, @malbouis, @francescobrivio can you please check and sign again.

[mmusich]

@cmsbuild, please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0e0442/22738/summary.html
COMMIT: c975a7d
CMSSW: CMSSW_12_3_X_2022-03-01-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37066/22738/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @mmusich Fix BeamSpotAnalyzer::fillDescriptions #37085

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0e0442/22738/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0e0442/22738/git-merge-result

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 3 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 4000857
• DQMHistoTests: Total failures: 8
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 4000827
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 204 log files, 45 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[tvami]

+db

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1