Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[123X] Migrate DQM clients to Run3 era #37101

Merged

Conversation

francescobrivio
Copy link
Contributor

@francescobrivio francescobrivio commented Mar 1, 2022

PR description:

As this week's ORM, I took the liberty of forward-porting #37081

Change process = cms.Process("name") to process = cms.Process("name", Run3)
following suggestion at #36947 (comment)
Similar to #36959

PR validation:

Backport already deployed succesfully in P5 online DQM machines

Backport

Forward-port of #37081

FYI @pmandrik

@tvami
Copy link
Contributor

tvami commented Mar 1, 2022

@cmsbuild , please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 1, 2022

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37101/28596

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 1, 2022

A new Pull Request was created by @francescobrivio for master.

It involves the following packages:

  • DQM/Integration (dqm)

@emanueleusai, @ahmad3213, @jfernan2, @rvenditti, @pbo0, @pmandrik can you please review it and eventually sign? Thanks.
@threus, @batinkov, @battibass this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 1, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cc4d2d/22741/summary.html
COMMIT: b5fea2e
CMSSW: CMSSW_12_3_X_2022-03-01-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37101/22741/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 7 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 4000857
  • DQMHistoTests: Total failures: 13
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 4000821
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 204 log files, 45 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@ahmad3213
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2022

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Mar 7, 2022

+1

@cmsbuild cmsbuild merged commit 80ef9d7 into cms-sw:master Mar 7, 2022
@francescobrivio francescobrivio deleted the alca-DQMclientsUpdate_12_3_X branch March 26, 2022 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants