Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DQM (offline + HLTEvF) HLT track monitoring for Run3 era #37177

Merged
merged 1 commit into from Mar 9, 2022

Conversation

mmasciov
Copy link
Contributor

@mmasciov mmasciov commented Mar 8, 2022

PR description:

Along the line of PR #37090, this PR updates DQM HLT track monitoring for Run3, removing deprecated collections.
After confirming with @RSalvatico and @ram1123 (for EGM), this PR also updates EGM track monitoring with the same purpose.

FYI: @mmusich, @vmariani, @AdrianoDee, @kjpena, @slezki

PR validation:

PR is technical, with no change in physics: only collections monitored in DQM are updated for Run3.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2022

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37177/28744

  • This PR adds an extra 24KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2022

A new Pull Request was created by @mmasciov (Mario Masciovecchio) for master.

It involves the following packages:

  • DQM/HLTEvF (dqm, hlt)
  • DQMOffline/Trigger (dqm)

@Martin-Grunewald, @emanueleusai, @ahmad3213, @cmsbuild, @missirol, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please review it and eventually sign? Thanks.
@HuguesBrun, @missirol, @silviodonato, @mtosi, @Fedespring, @calderona, @sscruz, @jhgoh, @trocino, @cericeci, @rociovilar this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@missirol
Copy link
Contributor

missirol commented Mar 8, 2022

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-95cee3/22945/summary.html
COMMIT: ade6aab
CMSSW: CMSSW_12_3_X_2022-03-08-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37177/22945/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3977034
  • DQMHistoTests: Total failures: 8
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3977003
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -30288.129 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 11634.0,... ): -2541.735 KiB HLT/EGM
  • DQMHistoSizes: changed ( 11634.0,... ): -1786.338 KiB HLT/Tracking
  • DQMHistoSizes: changed ( 138.4 ): -1777.951 KiB HLT/Tracking
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 204 log files, 45 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@missirol
Copy link
Contributor

missirol commented Mar 9, 2022

+hlt

  • outputs look as expected, as far as I can tell: O(1k) MEs are removed in Run-3 wfs, and those MEs were empty pre-PR (at least the ones I checked)

@jfernan2
Copy link
Contributor

jfernan2 commented Mar 9, 2022

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 9, 2022

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Mar 9, 2022

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants