Removing assert to address the issue #35668

[tsusa]

PR description:

This PR comments the assert statement in order to address the issue #35668.

The assert statement checks if the clusters on one detId are stored by increasing clust.originalId(). That is true for Legacy clusters coming from the Legacy Clusterizer, however if the Legacy clusters are output by SiPixelDigisClustersFromSoA that is no more true and the assert fails.

PR validation:

Run wfs 11634.501, 11634.502 (on CPU and GPU), 11634.506 and
hltGetConfiguration /dev/CMSSW_12_3_0/GRun --globaltag 122X_mcRun3_2021_realistic_v5 --mc --customise HLTrigger/Configuration/customizeHLTforPatatrack.customiseCommon,HLTrigger/Configuration/customizeHLTforPatatrack.customisePixelLocalReconstruction --input file:/eos/cms/store/relval/CMSSW_12_3_0_pre2/RelValQCD_FlatPt_15_3000HS_14/GEN-SIM-DIGI-RAW/122X_mcRun3_2021_realistic_v5-v1/2580000/9681546e-e170-41e0-aca3-280a014ba2cc.root --era Run3 --output minimal --max-events 1 > hlt.py

All work fine.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37193/28779

• This PR adds an extra 12KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File RecoLocalTracker/SiPixelRecHits/plugins/SiPixelRecHitSoAFromLegacy.cc modified in PR(s): Use cooperative groups to populate Associations (Histograms) in Pixel Patatrack #35713

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37193/28779/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37193/28779/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[jpata]

perhaps remove it altogether, rather than commenting out?

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37193/28781

• This PR adds an extra 12KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File RecoLocalTracker/SiPixelRecHits/plugins/SiPixelRecHitSoAFromLegacy.cc modified in PR(s): Use cooperative groups to populate Associations (Histograms) in Pixel Patatrack #35713

[cmsbuild]

A new Pull Request was created by @tsusa (Tatjana Susa) for master.

It involves the following packages:

• RecoLocalTracker/SiPixelRecHits (reconstruction)

@jpata, @cmsbuild, @clacaputo, @slava77 can you please review it and eventually sign? Thanks.
@mtosi, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @OzAmram, @ferencek, @dkotlins, @gpetruc, @mmusich, @threus, @tvami this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37193/28782

• This PR adds an extra 12KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File RecoLocalTracker/SiPixelRecHits/plugins/SiPixelRecHitSoAFromLegacy.cc modified in PR(s): Use cooperative groups to populate Associations (Histograms) in Pixel Patatrack #35713

[cmsbuild]

Pull request #37193 was updated. @jpata, @cmsbuild, @clacaputo, @slava77 can you please check and sign again.

[sroychow]

@cmsbuild please test

[sroychow]

enable gpu

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-263c48/23021/summary.html
COMMIT: 071fc68
CMSSW: CMSSW_12_3_X_2022-03-10-1100/slc7_amd64_gcc10
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37193/23021/install.sh to create a dev area with all the needed externals and cmssw changes.

GPU Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 4
• DQMHistoTests: Total histograms compared: 19811
• DQMHistoTests: Total failures: 1475
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 18336
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 3 files compared)
• Checked 12 log files, 9 edm output root files, 4 DQM output files
• TriggerResults: no differences found

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3695161
• DQMHistoTests: Total failures: 19
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3695119
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 48 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 204 log files, 45 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[jpata]

+reconstruction

• technical, removes the assert, which is known not to be satisfiable

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1

[mmusich]

@sroychow @tsusa does this need to be backported?
(thinking about a possible backport of #37174 which was stated targeting 12_3_X: #37174 (comment))

[sroychow]

@mmusich I think yes. The DQM PR is still to be merged in master. I can make backports for both these PR.