Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert back endJob to endRun done my mistake -> get back efficiency plot... #3720

Merged
merged 1 commit into from May 8, 2014

Conversation

acaudron
Copy link

@acaudron acaudron commented May 7, 2014

Revert back change from endJob to endRun done my mistake -> get back efficiency plots in RelVal production.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 7, 2014

A new Pull Request was created by @acaudron for CMSSW_7_1_X.

Revert back endJob to endRun done my mistake -> get back efficiency plot...

It involves the following packages:

Validation/RecoB

@ojeda, @danduggan, @rovere, @cmsbuild, @nclopezo, @deguio, @Degano can you please review it and eventually sign? Thanks.
@ferencek, @pvmulder this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2014

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2014

@deguio
Copy link
Contributor

deguio commented May 8, 2014

+1
@acaudron are you going to split the analysers in Source+Harvesting? I don't remember what we agreed.
thanks,
F.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

@acaudron
Copy link
Author

acaudron commented May 8, 2014

@deguio : yes I will do but this is a short fix needed in the next 710preX releases in order to get back the efficiencies there produced automatically during the RelVal production. I will try to find time to split the modules before end of 710 cycle.

ktf added a commit that referenced this pull request May 8, 2014
Reco -- Revert back endJob to endRun done my mistake -> get back efficiency plot...
@ktf ktf merged commit d20eeaf into cms-sw:CMSSW_7_1_X May 8, 2014
@deguio
Copy link
Contributor

deguio commented May 8, 2014

thanks @acaudron

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants