L1T ASAN heap-buffer-overflow fix resulting from PR #36919

[gk199]

PR description:

Fixing the heap-buffer-overflow in l1t::stage2::CaloLayer1Packer::makeHCalTPGs() resulting from PR #36919, and identified in Issue #37012. One file is changed: CaloLayer1Packer.cc, moving the loop that sets fg_bits to inside the conditional to ensure that this is only done when id is found. fg_bits is declared as a uint_32, and the bit setting is done via |= (more robust than the initial implementation).

PR validation:

Passed runTheMatrix.py in CMSSW_12_3_X_2022-03-14-1100.

In CMSSW_12_4_ASAN_X_2022-03-14-1100, step2 heap-buffer-overflow is resolved, tested with runTheMatrix.py -l 39834.0.

if this PR is a backport please specify the original PR and why you need to backport that PR:

Fix to PR #36919. Would like to be included in CMSSW_12_3_0.

[cmsbuild]

A new Pull Request was created by @gk199 (Gillian Kopp) for CMSSW_12_3_X.

It involves the following packages:

• EventFilter/L1TRawToDigi (l1)

@epalencia, @cmsbuild, @cecilecaillol, @rekovic can you please review it and eventually sign? Thanks.
@dinyar, @missirol, @Martin-Grunewald, @thomreis, @eyigitba this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

• Backported from L1T ASAN heap-buffer-overflow fix resulting from PR #36919 (12_4_X) #37257

[epalencia]

Please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c6ae3f/23140/summary.html
COMMIT: 24cd926
CMSSW: CMSSW_12_3_X_2022-03-15-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37253/23140/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3695161
• DQMHistoTests: Total failures: 5
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3695134
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 204 log files, 45 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[qliphy]

@gk199 Please make a forward PR to current master, i.e. 12_4_X

[cecilecaillol]

+l1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

@cms-sw/l1-l2 Please also check and sign the master PR #37257

[perrotta]

backport of #37257

[qliphy]

+1