New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to D88 wfs and clean up #37264
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37264/28888
|
A new Pull Request was created by @srimanob (Phat Srimanobhas) for master. It involves the following packages:
@jordan-martins, @bbilin, @wajidalikhan, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test |
-1 Failed Tests: RelVals RelVals |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37264/28889
|
Pull request #37264 was updated. @jordan-martins, @bbilin, @wajidalikhan, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen can you please check and sign again. |
@cmsbuild please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37264/28898
|
Pull request #37264 was updated. @jordan-martins, @bbilin, @wajidalikhan, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen can you please check and sign again. |
test parameters:
|
@cmsbuild please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fc5bf4/23204/summary.html Comparison Summary@slava77 comparisons for the following workflows were not done due to missing matrix map:
Summary:
|
+Upgrade Re-sign. Note that there is no increasing of wfs in the short matrix. Obsolete ones are removed also. We can clean up D77 NoPU later. Note to @cms-sw/reconstruction-l2 that there are two new wfs added to the short matrix, 39434.911 and 39634.999. In case you would like to add them for comparison in future. |
+pdmv |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
There is an issue with step-2 in IB. I assume it relates to the MinBias. From the IB log, it tries to pick up the MinBias dataset as follows, which exists if I check with DAS. The dataset is on disk at CERN. The PR test with wf 39661.97 was also done with MinBias for mixing, Any idea on what exactly happen @qliphy @perrotta @smuzaffar ? Thanks. IB log:
Error:
|
@srimanob There is also a related unit failure in the same IB: @smuzaffar may comment more, but could it be a glitch? Anyway I tried to run 39634.21 locally with this IB and everything works well... |
This is a new das query which was never cached by our system. So during relval tests we used direct [a] |
numWFIB.extend([23434.99,23434.999]) #2026D49 premixing combined stage1+stage2 (ttbar+PU200, ttbar+PU50 for PR test) | ||
numWFIB.extend([23234.21,23434.21,23434.9921]) #2026D49 prodlike, prodlike PU, prodlike premix stage1+stage2 | ||
numWFIB.extend([23234.103]) #2026D49 aging | ||
numWFIB.extend([23234.9]) #2026D49 vector hits |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
may I ask why this was removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I moved it to D88, 39434.9
. Do you still need it for D49, for PR test?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @srimanob, no that's fine, provided there is at least one VH workflow exercised in IBs, I didn't see it was migrated, sorry.
PR description:
This PR follows the green light of D88 validation report at PPD General (March 17)
The PU workflow of D88 is added to IB. In addition, DD4hep wf of D88 is added to the short matrix, and there is a clean up in the list of the short matrix and IB workflows.
PR validation:
if this PR is a backport please specify the original PR and why you need to backport that PR:
Not a backport, and no need of backport.