Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated path to EDM file for TSG tests on Run-3 Data [12_2_X] #37292

Merged
merged 1 commit into from Mar 23, 2022

Conversation

missirol
Copy link
Contributor

backport of #37283

PR description:

Partial backport of #37283. With respect to the original PR, this backport includes only the fix to the path of the EDM file used for TSG tests on Run-3 Data.

PR validation:

Relies on the tests done for the original PR.

If this PR is a backport, please specify the original PR and why you need to backport that PR:

#37283

This partial backport is needed to fix a problem with file access in the "HLT-Validation" tests of the IBs.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 21, 2022

A new Pull Request was created by @missirol (Marino Missiroli) for CMSSW_12_2_X.

It involves the following packages:

  • HLTrigger/Configuration (hlt)

@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @silviodonato this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@missirol
Copy link
Contributor Author

type bugfix

This is meant to fix the failure of the "HLT-Validation" tests in recent 12_2_X IBs, e.g. CMSSW_12_2_X_2022-03-20-0000.

@missirol
Copy link
Contributor Author

+hlt

Signing in advance. This file does not get tested in PR tests, and the signature should anyway trigger the tests (I want to check if it does).

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_2_X IBs after it passes the integration tests and once validation in the development release cycle CMSSW_12_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e542cb/23257/summary.html
COMMIT: 3b85b7a
CMSSW: CMSSW_12_2_X_2022-03-21-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37292/23257/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 42
  • DQMHistoTests: Total histograms compared: 3251324
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3251302
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 41 files compared)
  • Checked 177 log files, 37 edm output root files, 42 DQM output files
  • TriggerResults: no differences found

@Martin-Grunewald
Copy link
Contributor

Martin-Grunewald commented Mar 22, 2022

This still does not work for me, presumably because I now need grid access to run this, as the file is not at cern.

This may be a performance problem, and so far I did not need to set up grid access to run the TSG tests.

Unfortunatley, running voms-proxy-init -voms cms -rfc gves me: voms-proxy-init: Command not found.

@missirol
Copy link
Contributor Author

Should we then simply keep this EDM file in the TSG area on EOS?

@Martin-Grunewald
Copy link
Contributor

Yes, that would be better indeed! Sorry for going back to your original.

@Martin-Grunewald
Copy link
Contributor

Then actually we should update the addOnHLT tests to use the eos location as well.

@missirol
Copy link
Contributor Author

Okay, will do (in both/all PRs).

@cmsbuild
Copy link
Contributor

Pull request #37292 was updated. @cmsbuild, @missirol, @Martin-Grunewald can you please check and sign again.

@missirol
Copy link
Contributor Author

please test

Then actually we should update the addOnHLT tests to use the eos location as well.

I had forgotten the update of the file-path in the addOnTests. Will propagate that to the PRs in 12_3_X and 12_4_X.

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e542cb/23296/summary.html
COMMIT: eb7402d
CMSSW: CMSSW_12_2_X_2022-03-22-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37292/23296/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 42
  • DQMHistoTests: Total histograms compared: 3251324
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3251296
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 41 files compared)
  • Checked 177 log files, 37 edm output root files, 42 DQM output files
  • TriggerResults: no differences found

@missirol
Copy link
Contributor Author

+hlt

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 7b13a18 into cms-sw:CMSSW_12_2_X Mar 23, 2022
@missirol missirol deleted the devel_hltIntegTests_122X branch March 27, 2022 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants